Bug 13052 - OPAC Cart JavaScript is included twice in the footer
Summary: OPAC Cart JavaScript is included twice in the footer
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 13:40 UTC by Owen Leonard
Modified: 2015-06-04 23:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13052 - OPAC Cart JavaScript is included twice in the footer (2.46 KB, patch)
2014-10-09 13:45 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 13052 - OPAC Cart JavaScript is included twice in the footer (2.47 KB, patch)
2014-10-14 12:50 UTC, Chris Cormack 		Details | Diff | Splinter Review
[PASSED QA] Bug 13052 - OPAC Cart JavaScript is included twice in the footer (2.60 KB, patch)
2014-10-14 13:57 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-09 13:40:22 UTC 
The template logic for including the Cart's JavaScript file is doubled up in the OPAC footer include. One instance should be removed.
Comment 1 Owen Leonard 2014-10-09 13:45:44 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-14 12:50:15 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-14 13:57:27 UTC 
Created attachment 32312 [details] [review]
[PASSED QA] Bug 13052 - OPAC Cart JavaScript is included twice in the footer

The external JavaScript file which powers the OPAC Cart should not be
included twice. The correct instance is the one which comes after the
definition of MSG strings.

To test you must have the opacbookbag system preference turned on. In
Bootstrap OPAC, test adding some items to the Cart and confirm that Cart
operations work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Cart is still working as expected, passes tests and QA script.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-10-15 16:00:31 UTC 
Patch pushed to master.

Thanks Owen!