Created attachment 32293 [details] noEnterSubmit Tested in koha-common 3.16.4. When trying to input text in a textarea html tag while cataloging the "intro" key does not funcion. Needs to fix file intranet-tmpl/prog/*LANG*/js/cataloging.js In LINE 486 erase 'noEnterSubmit' parameter in function addClass. So: - $(".input_marceditor, .indicator").addClass('noEnterSubmit'); + $(".input_marceditor, .indicator").addClass('');
Created attachment 32363 [details] [review] Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, only to input The application of the "noEnterSubmit" class to textareas in the cataloging editor prevents the user from being able to use the Enter key to create line breaks. This is not intentional and should be corrected. This patch adds more specific scoping to the relevant JavaScript. To test, apply the patch and clear your browser cache if necessary. Open up the MARC editor and locate a tag which uses a textarea for entry. Try typing lines of text separated by line breaks. The enter key should work correctly.
(In reply to Owen Leonard from comment #1) > Created attachment 32363 [details] [review] [review] > Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, > only to input > > The application of the "noEnterSubmit" class to textareas in the > cataloging editor prevents the user from being able to use the Enter key > to create line breaks. This is not intentional and should be corrected. > > This patch adds more specific scoping to the relevant JavaScript. > > To test, apply the patch and clear your browser cache if necessary. Open > up the MARC editor and locate a tag which uses a textarea for entry. Try > typing lines of text separated by line breaks. The enter key should work > correctly. Tested and the enter key works correctly!! Great job!
Tested and the enter key works correctly!! Great job!
Hi Bondiurbano, thx for testing! - I have added a sing-off line for you on the patch. If you are using the sandboxes for testing they can do that for you too.
Created attachment 32421 [details] [review] [PASSED QA] Bug 13080 - Addition of noEnterSubmit class should not apply to textarea, only to input The application of the "noEnterSubmit" class to textareas in the cataloging editor prevents the user from being able to use the Enter key to create line breaks. This is not intentional and should be corrected. This patch adds more specific scoping to the relevant JavaScript. To test, apply the patch and clear your browser cache if necessary. Open up the MARC editor and locate a tag which uses a textarea for entry. Try typing lines of text separated by line breaks. The enter key should work correctly. Signed-off-by: bondiurbano costalc@gmail.com Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and fixes the problem.
Patch pushed to master. Thanks Owen!
Can this be backported to 3.16.x ?