($biblio->{author}) and $_->{bib_summary} .= " by " . $biblio->{author};
Created attachment 32556 [details] [review] Bug 13083 - Hard-coded " by " in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly.
This is OK for MARC21 but won't be that good for UNIMARC: - In MARC21, if you have a title and a subtitle, the title (245$a) ends with ':', and so your patch will display correctly separated title and subtile. - In UNIMARC, puncuation characters are not stored in field, ie the title doesn't end with a ':'. The display layer is in charge to add punctuation characters. That what UNIMARC XSL is doing. Am I wrong or do you have already proposed a patch to display tagged biblio records with XSL?
Created attachment 32751 [details] [review] Bug 13083 - Hard-coded " by " in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I agree that the display in UNIMARC is not ideal with this patch, but I still believe it to be an improvement over the hardcoded and untranslatable 'by' that was used before. Also, looking at some other code samples, the UNIMARC display of title + subtitle seems to be a more general problem - so maybe we can fix them all at once in a later patch. The XSLT patch from Owen depends on this one.
Created attachment 32770 [details] [review] [PASSED QA] Bug 13083 - Hard-coded " by " in opac-tags.pl The OPAC's list of a logged-in user's tagged titles displays title and author, which for some reason are combined in the script into one variable. I can't see any reason to do it this way. This patch modifies the script so that title and author are passed as separate variables. In addition, subtitle is now passed as well. To test you must log into the OPAC as a user who has tagged multiple titles, at least one of which should have an author and at least one with a subtitle. View the list of tagged titles and confirm that this information is being displayed correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script.
Patch pushed to master. Thanks Owen!