Bug 13095 - An email will be sent shortly
Summary: An email will be sent shortly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-16 11:36 UTC by Marcel de Rooy
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13095: An email will be sent shortly (3.03 KB, patch)
2014-10-16 12:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 13095: An email will be sent shortly (3.08 KB, patch)
2014-10-23 18:36 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13095: An email will be sent shortly (3.18 KB, patch)
2014-10-23 22:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2014-10-16 11:36:53 UTC

    
Comment 1 Marcel de Rooy 2014-10-16 12:02:56 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-23 18:36:27 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-23 22:03:02 UTC
Created attachment 32647 [details] [review]
[PASSED QA] Bug 13095: An email will be sent shortly

This patch adjusts two instances where Koha says that an email has
been sent while it is just enqueued (put in the message queue). The
crontab example still suggests to run process_message_queue once an hour
and the manual even speaks about 1-4 hours.

In the process of selfregistration and sharing a shelf, I have adjusted
the text "has been sent" to "will be sent shortly". This covers imo
the one-hour frequency.

When writing this patch, I have examined all calls of EnqueueLetter;
I only found these two occurrences to be of interest.

Note: I would recommend to increase this frequency in the documentation,
but consider that for now to be outside the scope of this report.

Test plan:
[1] Self-register a new user with verification by email required. Look at
    the text when you submit your data.
[2] Share a list with someone else. Look at the text when you submit the
    invitation.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, small string change.
Comment 4 Tomás Cohen Arazi 2014-10-28 13:55:32 UTC
Patch pushed to master.

Thanks Marcel!