Bug 13105 - Columns misplaced in member search result
Summary: Columns misplaced in member search result
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Rafal Kopaczka
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-17 14:21 UTC by Rafal Kopaczka
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Columns misplaced (23.41 KB, image/png)
2014-10-17 14:21 UTC, Rafal Kopaczka 		Details
Bug 13105: Columns misplaced in member search result (1.27 KB, patch)
2014-10-17 14:24 UTC, Rafal Kopaczka 		Details | Diff | Splinter Review
Bug 13105: Columns misplaced in member search result (1.32 KB, patch)
2014-10-19 19:11 UTC, Chris Cormack 		Details | Diff | Splinter Review
[PASSED QA] Bug 13105: Columns misplaced in member search result (1.44 KB, patch)
2014-10-21 22:09 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafal Kopaczka 2014-10-17 14:21:52 UTC 
Created attachment 32504 [details]
Columns misplaced

When staff member, without manage_patron_lists permissions, search for patrons on result page, he gets table with additional column in head table.
Comment 1 Rafal Kopaczka 2014-10-17 14:24:58 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-19 19:11:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-21 22:09:17 UTC 
Created attachment 32569 [details] [review]
[PASSED QA] Bug 13105: Columns misplaced in member search result

When staff member, without manage_patron_lists permissions, search for
patrons on result page, he gets table with additional column in head
table.
Test plan:
Log in as staff member without manage_patron_lists permissions, search
for any patron.
Check that table with results is fine now.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes problem by adding a permission check to the template.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-10-30 04:28:01 UTC 
Patch pushed to master.

Thanks Rafal!