It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id
Created attachment 32576 [details] [review] Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id Test Plan: 1) Apply this patch 2) Log into Koha 3) Inspect the html source code 4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span> 5) Note the logged in branch name is now surrounded by a span with an id 6) Note below that is a span containing the branchcode, also with an id. 7) Verify the branchcode span is hidden by default.
Created attachment 32577 [details] [review] [SIGNED-OFF] Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id Test Plan: 1) Apply this patch 2) Log into Koha 3) Inspect the html source code 4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span> 5) Note the logged in branch name is now surrounded by a span with an id 6) Note below that is a span containing the branchcode, also with an id. 7) Verify the branchcode span is hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 32741 [details] [review] [PASSED QA] Bug 13128 - Add span with id for logged in branch name, add hidden span for branchcode It would be nice if there were a simple way to access the name and branchcode of the currently logged in library, as well as the logged in user via JavaScript ( via intranetuserjs ). I propose the following: 1) Remove the whitespace surrounding the loggedinusername span 2) Wrap the logged in branch name with a span that has an id 3) Add the branchcode in a hidden span that has an id Test Plan: 1) Apply this patch 2) Log into Koha 3) Inspect the html source code 4) Note the lack of whitespace within the tag <span class="loggedinusername">[% loggedinusername %]</span> 5) Note the logged in branch name is now surrounded by a span with an id 6) Note below that is a span containing the branchcode, also with an id. 7) Verify the branchcode span is hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small template change, no problems found.
Patch pushed to master. Thanks Kyle!