In most other places in Koha, you get a confirm delete message when clicking a delete button, but in saved reports you do not have this option; you choose to delete a single report, and don't get a confirmation message -- the report is immediately deleted. It would be nice if saved reports had a confirm delete button, just to catch accidental deletes.
Heather I can reproduce this bug in 3.14.05 but not in master or the latest 3.16.x. I think this has been fixed and should work correctly after your next upgrade.
Owen, We are on 3.16.4 (which I thought was the latest version of 3.16 when I reported this issue), and I am still not seeing a confirm delete message on Mac and PC versions of Firefox and Chrome...
Created attachment 33203 [details] [review] Bug 13132 - Report deletion confirmation doesn't work with DataTables pagination This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs.
This patch fixes a problem with save report deletion confirmation which appears when the user tries to delete a report found on a DataTables page > 1. This patch alters the trigger to accommodate links which are not initially shown. A small addition has been made to automatically close the menu when the delete link is clicked. Test Plan: To test you must have, at the very least, greater than 10 saved reports. - If necessary change the number of entries shown so that there is a "next" page of results. - Navigate to a subsequent page, click the "Action" menu, and choose "Delete" for one of your saved reports. - A confirmation message should appear. -- Clicking "OK" should complete the deletion. -- Clicking "Cancel" should cancel the deletion. - Confirm that deletion confirmations work from the first page and from other tabs. Thanks Owen!
I am sorry, but I am not able to see the problem on current master. I tried with 11 reports, set the page to 10, went on the second page. Tried the menu and the checkbox + button below the table. I always got the confirmation dialog. I tried from the all tab and form the acqusitions tab. What is missing?
I can reproduce this 3.19.00.016.
In Version 3.23, I can delete from the drop down menu from my list of guided reports and a confirmation message will show up. However no confirmation message shows up when I try to delete from the toolbar.
Created attachment 49659 [details] [review] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar To test: 1) Go to Reports -> Use saved (or build a new one if you have none saved) 2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel. 3) Click Show in the drop down menu 4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page. Spponsored-by: Catalyst IT
Created attachment 49668 [details] [review] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar To test: 1) Go to Reports -> Use saved (or build a new one if you have none saved) 2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel. 3) Click Show in the drop down menu 4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page. Sponsored-by: Catalyst IT Signed-off-by: Magnus Enger <magnus@libriotech.no> After applying the patch I get a JavaScript popup confirmation when I click on the delete button, in the Show, Edit and Run views. Nice!
Created attachment 49701 [details] [review] [PASSED QA] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar To test: 1) Go to Reports -> Use saved (or build a new one if you have none saved) 2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel. 3) Click Show in the drop down menu 4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page. Spponsored-by: Catalyst IT Signed-off-by: Magnus Enger <magnus@libriotech.no> After applying the patch I get a JavaScript popup confirmation when I click on the delete button, in the Show, Edit and Run views. Nice! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 release. Thanks!
Not needed in stable versions (no delete button in toolbar), status changed to RESOLVED