Bug 13132 - Adding confirm message for deleting a report from the reports toolbar
Summary: Adding confirm message for deleting a report from the reports toolbar
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 02:03 UTC by HB-NEKLS
Modified: 2016-12-05 21:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13132 - Report deletion confirmation doesn't work with DataTables pagination (1.95 KB, patch)
2014-11-04 16:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13132: Add confirm dialog for deleting reports from the reports toolbar (1.86 KB, patch)
2016-03-29 23:30 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 13132: Add confirm dialog for deleting reports from the reports toolbar (2.04 KB, patch)
2016-03-30 06:12 UTC, Magnus Enger
Details | Diff | Splinter Review
[PASSED QA] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar (2.10 KB, patch)
2016-03-30 22:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description HB-NEKLS 2014-10-23 02:03:37 UTC
In most other places in Koha, you get a confirm delete message when clicking a delete button, but in saved reports you do not have this option; you choose to delete a single report, and don't get a confirmation message -- the report is immediately deleted. It would be nice if saved reports had a confirm delete button, just to catch accidental deletes.
Comment 1 Owen Leonard 2014-10-31 13:49:24 UTC
Heather I can reproduce this bug in 3.14.05 but not in master or the latest 3.16.x. I think this has been fixed and should work correctly after your next upgrade.
Comment 2 HB-NEKLS 2014-11-03 20:37:29 UTC
Owen, We are on 3.16.4 (which I thought was the latest version of 3.16 when I reported this issue), and I am still not seeing a confirm delete message on Mac and PC versions of Firefox and Chrome...
Comment 3 Owen Leonard 2014-11-04 16:29:08 UTC Comment hidden (obsolete)
Comment 4 HB-NEKLS 2014-11-04 17:56:50 UTC
This patch fixes a problem with save report deletion confirmation which
appears when the user tries to delete a report found on a
DataTables page > 1.

This patch alters the trigger to accommodate links which are not
initially shown. A small addition has been made to automatically close
the menu when the delete link is clicked.

Test Plan: 

To test you must have, at the very least, greater than 10 saved reports.

- If necessary change the number of entries shown so that there is a
  "next" page of results.
- Navigate to a subsequent page, click the "Action" menu, and choose
  "Delete" for one of your saved reports.
- A confirmation message should appear.
  -- Clicking "OK" should complete the deletion.
  -- Clicking "Cancel" should cancel the deletion.
- Confirm that deletion confirmations work from the first page and from
  other tabs.

Thanks Owen!
Comment 5 Katrin Fischer 2014-11-05 20:46:14 UTC
I am sorry, but I am not able to see the problem on current master. I tried with 11 reports, set the page to 10, went on the second page. Tried the menu and the checkbox + button below the table. I always got the confirmation dialog. 
I tried from the all tab and form the acqusitions tab.

What is missing?
Comment 6 Tom Misilo 2015-04-18 00:11:11 UTC
I can reproduce this 3.19.00.016.
Comment 7 Aleisha Amohia 2016-03-29 23:27:02 UTC
In Version 3.23, I can delete from the drop down menu from my list of guided reports and a confirmation message will show up. However no confirmation message shows up when I try to delete from the toolbar.
Comment 8 Aleisha Amohia 2016-03-29 23:30:52 UTC Comment hidden (obsolete)
Comment 9 Magnus Enger 2016-03-30 06:12:54 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2016-03-30 22:23:46 UTC
Created attachment 49701 [details] [review]
[PASSED QA] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar

To test:

1) Go to Reports -> Use saved (or build a new one if you have none saved)
2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel.
3) Click Show in the drop down menu
4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page.

Spponsored-by: Catalyst IT
Signed-off-by: Magnus Enger <magnus@libriotech.no>
After applying the patch I get a JavaScript popup confirmation when
I click on the delete button, in the Show, Edit and Run views. Nice!

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Brendan Gallagher 2016-03-31 18:52:00 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 12 Julian Maurice 2016-04-06 13:33:54 UTC
Not needed in stable versions (no delete button in toolbar), status changed to RESOLVED