Clicking on the help button on the "Manage label Layouts" screen brings up a pop-up window with the following text: Online help Sorry, there is no help available for this topic, please refer to the Koha 3.16 manual (online). At the very least this should point to '2.5.3.1. Add a Layout'
Still valid on current master.
Created attachment 45470 [details] [review] [BUG 13136] Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage
(In reply to Nicole C. Engard from comment #2) > Created attachment 45470 [details] [review] [review] > [BUG 13136] Add missing help file for label-manage.pl > > This patch adds in a help file for the new label-manage page. > > To test: > > * visit label creator > * click manage and choose an option > * click 'help' and confirm the file loads > * repeat for all options under manage I have a problem when attaching the patch with git bz UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in position 54: ordinal not in range(128) I don't know if only is my problem, please confirm
QA tools complain about tab chars in prog/en/modules/help/labels/label-manage.tt forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 69)
(In reply to Héctor Eduardo Castro Avalos from comment #3) (...) > > I have a problem when attaching the patch with git bz > > UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in > position 54: ordinal not in range(128) > > I don't know if only is my problem, please confirm The character \u203a' is a quote character that looks like '>' In earlier commits, I produced such errors by copy-pasting the breadcrumbs from the staff client (like Home > Tools > Label creator) to the commit message.
(In reply to Marc Véron from comment #5) > The character \u203a' is a quote character that looks like '>' > In earlier commits, I produced such errors by copy-pasting the breadcrumbs > from the staff client (like Home > Tools > Label creator) to the commit > message. I've tried to change to a valid > also I changed the tab char but I couldn't attach it.
Created attachment 45532 [details] [review] [SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised
QA Tool FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/labels/label-manage.tt FAIL forbidden patterns forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 70) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 65) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 69) The patch fails because summary has character \u203a'
Created attachment 45536 [details] [review] [SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tab char corrected
Hi Nicole I changed the summary or title of the bug and I fixed the tab char up. The bug remained authored by you. Regards
Created attachment 45561 [details] [review] Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tab char corrected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master. Thanks for your contribution!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.