Bug 13136 - Add documentation for Home > Tools > Labels home > Manage label Layouts
Summary: Add documentation for Home > Tools > Labels home > Manage label Layouts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Nicole C. Engard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 13:48 UTC by Barton Chittenden
Modified: 2016-12-05 21:25 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
[BUG 13136] Add missing help file for label-manage.pl (7.94 KB, patch)
2015-12-07 19:21 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl (8.03 KB, patch)
2015-12-09 15:11 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 13136: Add missing help file for label-manage.pl (8.07 KB, patch)
2015-12-09 15:37 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 13136: Add missing help file for label-manage.pl (8.13 KB, patch)
2015-12-10 10:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2014-10-23 13:48:49 UTC
Clicking on the help button on the "Manage label Layouts" screen brings up a pop-up window with the following text:

Online help
Sorry, there is no help available for this topic, please refer to the Koha 3.16 manual (online).

At the very least this should point to '2.5.3.1. Add a Layout'
Comment 1 Marc Véron 2015-09-06 18:05:01 UTC
Still valid on current master.
Comment 2 Nicole C. Engard 2015-12-07 19:21:58 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2015-12-08 05:44:45 UTC
(In reply to Nicole C. Engard from comment #2)
> Created attachment 45470 [details] [review] [review]
> [BUG 13136] Add missing help file for label-manage.pl
> 
> This patch adds in a help file for the new label-manage page.
> 
> To test:
> 
> * visit label creator
> * click manage and choose an option
> * click 'help' and confirm the file loads
> * repeat for all options under manage

I have a problem when attaching the patch with git bz

UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in position 54: ordinal not in range(128)

I don't know if only is my problem, please confirm
Comment 4 Marc Véron 2015-12-08 10:53:50 UTC
QA tools complain about tab chars in prog/en/modules/help/labels/label-manage.tt

forbidden pattern: tab char (line 36)
forbidden pattern: tab char (line 70)
forbidden pattern: tab char (line 34)
forbidden pattern: tab char (line 41)
forbidden pattern: tab char (line 42)
forbidden pattern: tab char (line 65)
forbidden pattern: tab char (line 39)
forbidden pattern: tab char (line 69)
Comment 5 Marc Véron 2015-12-08 11:04:56 UTC
(In reply to Héctor Eduardo Castro Avalos from comment #3)
(...)
> 
> I have a problem when attaching the patch with git bz
> 
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u203a' in
> position 54: ordinal not in range(128)
> 
> I don't know if only is my problem, please confirm

The character \u203a' is a quote character that looks like '>'
In earlier commits, I produced such errors by copy-pasting the breadcrumbs from the staff client (like Home > Tools > Label creator) to the commit message.
Comment 6 Héctor Eduardo Castro Avalos 2015-12-09 00:17:19 UTC
(In reply to Marc Véron from comment #5)

> The character \u203a' is a quote character that looks like '>'
> In earlier commits, I produced such errors by copy-pasting the breadcrumbs
> from the staff client (like Home > Tools > Label creator) to the commit
> message.

I've tried to change to a valid > also I changed the tab char but I couldn't attach it.
Comment 7 Héctor Eduardo Castro Avalos 2015-12-09 15:11:48 UTC Comment hidden (obsolete)
Comment 8 Héctor Eduardo Castro Avalos 2015-12-09 15:27:06 UTC
QA Tool

FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/help/labels/label-manage.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 36)
		forbidden pattern: tab char (line 70)
		forbidden pattern: tab char (line 34)
		forbidden pattern: tab char (line 41)
		forbidden pattern: tab char (line 42)
		forbidden pattern: tab char (line 65)
		forbidden pattern: tab char (line 39)
		forbidden pattern: tab char (line 69)

The patch fails because summary has character \u203a'
Comment 9 Héctor Eduardo Castro Avalos 2015-12-09 15:37:42 UTC Comment hidden (obsolete)
Comment 10 Héctor Eduardo Castro Avalos 2015-12-09 15:43:02 UTC
Hi Nicole

I changed the summary or title of the bug and I fixed the tab char up.

The bug remained authored by you.

Regards
Comment 11 Jonathan Druart 2015-12-10 10:04:07 UTC
Created attachment 45561 [details] [review]
Bug 13136: Add missing help file for label-manage.pl

This patch adds in a help file for the new label-manage page.

To test:

* visit label creator
* click manage and choose an option
* click 'help' and confirm the file loads
* repeat for all options under manage

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Tab char corrected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jesse Weaver 2015-12-30 23:52:31 UTC
Pushed to master. Thanks for your contribution!
Comment 13 Julian Maurice 2015-12-31 13:29:40 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 14 Frédéric Demians 2015-12-31 18:34:33 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.