Bug 13139 - Move treeview jQuery plugin outside of language-specific directory
Summary: Move treeview jQuery plugin outside of language-specific directory
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 18:50 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13139 - Move treeview jQuery plugin outside of language-specific directory (2.03 KB, patch)
2014-10-23 18:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13042 - Move budget action links into menu (4.99 KB, patch)
2014-10-25 09:44 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 13139 - Move treeview jQuery plugin outside of language-specific directory (2.23 KB, patch)
2014-10-25 09:51 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 13139 - Move treeview jQuery plugin outside of language-specific directory (2.36 KB, patch)
2014-10-25 10:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-23 18:50:11 UTC
The jquery.treeview.pack.js jQuery plugin used by the patron permissions template should be moved to intranet-tmpl/lib/jquery/plugins
Comment 1 Owen Leonard 2014-10-23 18:59:35 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-10-25 09:44:04 UTC Comment hidden (obsolete)
Comment 3 Frédéric Demians 2014-10-25 09:44:50 UTC
Comment on attachment 32708 [details] [review]
Bug 13042 - Move budget action links into menu

>From 13af2940290d535991639d280c35f5999f7fb383 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 8 Oct 2014 10:06:34 -0400
>Subject: [PATCH] Bug 13042 - Move budget action links into menu
>
>The series of links in the "actions" column of the budgets
>administration summary table are not very readable as they are, all
>strung together: Edit Delete Duplicate Close Add fund.
>
>This patch moves the links into an "Actions" menu, similar to the change
>made by Bug 10615 in Reports.
>
>To test you should have multiple active and inactive budgets. Apply the
>patch and go to Administration -> Budgets. Confirm that each menu item
>links to the correct action. Test the menu for both active and inactive
>budgets.
>
>Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Nice improvement on template level, works as described.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>
>http://bugs.koha-community.org/show_bug.cgi?id=13139
>---
> .../prog/en/modules/admin/aqbudgetperiods.tt       | 36 ++++++++++++++++------
> 1 file changed, 26 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>index be49860..fab8c92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt
>@@ -1,5 +1,29 @@
> [% USE KohaDates %]
> [% USE format %]
>+[%- BLOCK action_menu %]
>+    <div class="dropdown">
>+        <a class="btn btn-mini dropdown-toggle" id="budgetmenu_[% block_budget_id %]" role="button" data-toggle="dropdown" href="#">
>+           Actions <b class="caret"></b>
>+        </a>
>+        <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="budgetmenu_[% block_budget_id %]">
>+              <li>
>+                  <a href="[% script_name %]?op=add_form&amp;budget_period_id=[% block_budget_id |html %]"><i class="icon-pencil"></i> Edit</a>
>+              </li>
>+              <li>
>+                  <a href="[% script_name %]?op=delete_confirm&amp;budget_period_id=[% block_budget_id %]"><i class="icon-remove"></i> Delete</a>
>+              </li>
>+              <li>
>+                  <a href="[% script_name %]?op=duplicate_form&amp;budget_period_id=[% block_budget_id %]"><i class="icon-copy"></i> Duplicate</a>
>+              </li>
>+              <li>
>+                  <a href="[% script_name %]?op=close_form&amp;budget_period_id=[% block_budget_id %]"><i class="icon-remove-sign"></i> Close</a>
>+              </li>
>+              <li>
>+                  <a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&amp;budget_period_id=[% block_budget_id %]"><i class="icon-plus"></i> Add fund</a>
>+              </li>
>+        </ul>
>+    </div>
>+[% END -%]
> [% INCLUDE 'doc-head-open.inc' %]
> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -540,11 +564,7 @@
>                 </td>
>                 <td class="data">[% period_active.budget_period_total %]</td>
>                 <td>
>-                  <a href="[% script_name %]?op=add_form&amp;budget_period_id=[% period_active.budget_period_id |html %]">Edit</a>
>-                  <a href="[% script_name %]?op=delete_confirm&amp;budget_period_id=[% period_active.budget_period_id %]">Delete</a>
>-                  <a href="[% script_name %]?op=duplicate_form&amp;budget_period_id=[% period_active.budget_period_id %]">Duplicate</a>
>-                  <a href="[% script_name %]?op=close_form&amp;budget_period_id=[% period_active.budget_period_id %]">Close</a>
>-                  <a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&amp;budget_period_id=[% period_active.budget_period_id %]">Add fund</a>
>+                    [% PROCESS action_menu block_budget_id=period_active.budget_period_id %]
>                 </td>
>                 </tr>
>               [% END %]
>@@ -577,11 +597,7 @@
>                   <td> [% IF ( period_loo.budget_period_locked ) %]<span style="color:green;">Locked</span>&nbsp;[% ELSE %][% END %] </td>
>                   <td class="data">[% period_loo.budget_period_total %]</td>
>                   <td>
>-                      <a href="[% script_name %]?op=add_form&amp;budget_period_id=[% period_loo.budget_period_id |html %]">Edit</a>
>-                      <a href="[% script_name %]?op=delete_confirm&amp;budget_period_id=[% period_loo.budget_period_id %]">Delete</a>
>-                      <a href="[% script_name %]?op=duplicate_form&amp;budget_period_id=[% period_loo.budget_period_id %]">Duplicate</a>
>-                      <a href="[% script_name %]?op=close_form&amp;budget_period_id=[% period_loo.budget_period_id %]">Close</a>
>-                  <a href="/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&amp;budget_period_id=[% period_loo.budget_period_id %]">Add fund</a>
>+                        [% PROCESS action_menu block_budget_id=period_loo.budget_period_id %]
>                   </td>
>                   </tr>
>               [% END %]
>-- 
>2.1.2
Comment 4 Frédéric Demians 2014-10-25 09:46:00 UTC
My row previous comments are just a mess procuced by a bad git-bz usage, I apologize for...
Comment 5 Frédéric Demians 2014-10-25 09:46:30 UTC
My two previous comments are just a mess procuced by a bad git-bz usage, I
apologize for...
Comment 6 Frédéric Demians 2014-10-25 09:51:44 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-10-25 10:29:00 UTC
Hi Frederic, please remember to obsolete the old patch when adding the signed off one. The easiest way is with git bz attach -e and then uncomment the line with the attachment.
Comment 8 Katrin Fischer 2014-10-25 10:34:23 UTC
Created attachment 32716 [details] [review]
[PASSED QA] Bug 13139 - Move treeview jQuery plugin outside of language-specific directory

This patch moves the treeview plugin in the staff client from the
language-specific lib/jquery/plugins directory to the one outside the
theme directory.

To test, apply the patch and view the "Set permissions" page for a
patron. The list of permissions should display in an expandable list as
usual.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

It works, following the test plan. I can see the jQuery treeview plugin moved
from 'prog' language specific directory to the global lib/plugins directory.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described. Found no other places where we use this plugin.
Comment 9 Tomás Cohen Arazi 2014-10-27 17:21:05 UTC
Patch pushed to master.

Thanks Owen!