Bug 13144 - Google transliteration does not work on bootstrap
Summary: Google transliteration does not work on bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Amit Gupta
QA Contact: Testopia
URL:
Keywords:
Depends on: 13211
Blocks: 13206
  Show dependency treegraph
 
Reported: 2014-10-25 07:41 UTC by Amit Gupta
Modified: 2015-06-04 23:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13144 - Google transliteration does not work on bootstrap (2.94 KB, patch)
2014-11-04 16:13 UTC, Amit Gupta
Details | Diff | Splinter Review
Bug 13144: Google transliteration does not work on bootstrap (3.30 KB, patch)
2014-11-05 07:15 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 13144: Google transliteration does not work on bootstrap (3.42 KB, patch)
2014-11-05 20:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug-13211: Added Google Indic Transliteration as a System Preference (3.54 KB, patch)
2014-11-06 13:14 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2014-10-25 07:41:34 UTC
Google transliteration does not work on bootstrap
Comment 1 Amit Gupta 2014-11-04 16:13:12 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-11-05 07:15:21 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-11-05 20:52:44 UTC
I think this should not stay an undocumented feature. At least the preference should not have to be manually added but be a part of the sys pref editor.
Comment 4 Katrin Fischer 2014-11-05 20:56:06 UTC
Created attachment 33272 [details] [review]
[PASSED QA] Bug 13144: Google transliteration does not work on bootstrap

To Test:
Use Google Indic Transliteration API to allow users to
transliterate english typed words into Indic languages.
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ae7b60962e7d07aa00a45a7af692939a4ce7aa6

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

I had been able to reproduce the bug (a regression), and I can confirm that
this patch fix it. But I had to create manualy GoogleIndicTransliteration
system preference, which doesn't exist in standard .pref file. It may be
necessary to add it. In my opinion, it shouldn't prevent to include this patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes a somewhat 'hidden' feature, no problems found.
Comment 5 Amit Gupta 2014-11-06 03:32:54 UTC
Hi Katrin,

Thanks will create Google Transliteration as a system preference. Please see 

Bug: 13211

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211
Comment 6 Amit Gupta 2014-11-06 04:31:24 UTC
Hi Katrin,

I have created the patch Bug: 13211. Please test.
Comment 7 Mark Tompsett 2014-11-06 13:14:41 UTC Comment hidden (obsolete)
Comment 8 Mark Tompsett 2014-11-06 13:18:49 UTC
(In reply to M. Tompsett from comment #7)
> Created attachment 33301 [details] [review] [review]
> Bug-13211: Added Google Indic Transliteration as a System Preference

Sorry for the blip. git bz thought it should attach here, because I applied 13144 in order to test 13211. I believe the status was passed QA before.
Comment 9 Tomás Cohen Arazi 2014-11-06 13:31:01 UTC
Patch pushed to master.

Thanks Amit!