Bug 13147 - Update German web installer sample files for 3.18
Summary: Update German web installer sample files for 3.18
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-26 20:49 UTC by Katrin Fischer
Modified: 2016-06-21 21:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13147: Update German web installer files for 3.18 (4.72 KB, patch)
2014-11-23 20:14 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 13147: Update German web installer files for 3.18 (4.73 KB, patch)
2014-11-23 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13147: Update German web installer files for 3.18 (5.05 KB, patch)
2014-11-26 19:12 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13147: Update German web installer files for 3.18 (5.07 KB, patch)
2014-11-26 23:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 13147: Update German web installer files for 3.18 (5.12 KB, patch)
2014-11-27 08:37 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-10-26 20:49:41 UTC
Translate new permissions, etc.
Comment 1 Katrin Fischer 2014-11-23 20:14:19 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2014-11-23 20:16:43 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-11-26 19:12:12 UTC Comment hidden (obsolete)
Comment 4 Tomás Cohen Arazi 2014-11-26 23:07:29 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-11-27 08:37:42 UTC
Created attachment 33979 [details] [review]
Bug 13147: Update German web installer files for 3.18

- Adds translations for new permissions
- Adds ISO code to the sample currencies
- Removes a comment line about branchrelations from
  sample_libraries (en)

To test:
- Run the German web installer with all sample data
  selected
- Verify it runs without problems
- If you speak German - verify the translations make sense

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

No errors from the web installer. I verified that all the changes I saw
in the diff appeared correctly in the permissions. Currencies all
appeared to be correct after installation. Translations appeared to be
very German-looking.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jonathan Druart 2014-11-27 08:38:41 UTC
I did *not* test this patch, bug all looks good.
I did not understand the change in installer/data/mysql/en/optional/sample_libraries.sql (remove 1 commented line, but not the other one), but not a bug deal.
Comment 7 Katrin Fischer 2014-11-27 08:51:15 UTC
Hi Tomas, please feel free to remove the comment change from the patch - I am not attached to it :)
Comment 8 Tomás Cohen Arazi 2014-11-27 14:07:06 UTC
Patch happily pushed to master :-D

Thanks Katrina