Because of this bug, installing Koha's default databse fails because sysprefs cannot be installed.
Created attachment 32789 [details] [review] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash.
Setting severity to major, because this seriously hampers newcomers from enjoying their seamless Koha experience.
Created attachment 32792 [details] [review] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql I've applied against master 3.17.00.031 Without this patch, on web-installing the DB, at the 3-rd step I saw: sysprefs.sql ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 431 After having applied the patch, web-installing the DB ends cleanly. So I pass the patch to "Signed Off" status.
I feel like the patch is not complete - all UsageStats* have the wrong field order. Testing a new patch.
Created attachment 32800 [details] [review] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above
My new patch applies on top of Kivilahti's, fixing the other UsageStats* prefs.
Created attachment 32803 [details] [review] [SIGNED-OFF] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 32804 [details] [review] [SIGNED-OFF] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors
Created attachment 32824 [details] [review] [PASSED QA] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 32825 [details] [review] [PASSED QA] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patches pushed to master. Thanks Olli and Katrina
Lol that was the fastest push to master ever. Thank you Katrin for spotting the bug and providing a fix! Good initiative!