Bug 13151 - staff marc preview not wrapping
Summary: staff marc preview not wrapping
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-27 17:14 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
example marc preview in staff (72.10 KB, image/png)
2014-10-27 17:14 UTC, Nicole C. Engard
Details
Bug 13151 - staff marc preview not wrapping (7.97 KB, patch)
2014-11-13 19:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13151 - staff marc preview not wrapping (8.08 KB, patch)
2014-11-14 08:59 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 13151 - staff marc preview not wrapping (8.16 KB, patch)
2014-11-21 16:29 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-10-27 17:14:28 UTC
Created attachment 32796 [details]
example marc preview in staff

When you're in the staff client and click the marc preview you link you have to scroll left to right to see the whole thing because it doesn't wrap.  In the OPAC it looks much cleaner. Could we use that layout in the staff client since the staff are the people who care about MARC - not the patrons.
Comment 1 Owen Leonard 2014-11-13 19:38:46 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2014-11-14 08:59:02 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-11-21 16:29:11 UTC
Created attachment 33796 [details] [review]
[PASSED QA] Bug 13151 - staff marc preview not wrapping

The MARC preview available on the staff client detail page doesn't wrap
long lines of text because it uses a huge block of whitespace-formatted
text in a <pre> tag. The OPAC doesn't have this problem because the MARC
preview is formated in a table.

This patch copies the OPAC's "plainMARC.xsl" file for use in the staff
client. The preview modal has been converted to use Bootstrap following
the method used in Bug 12755

To test, apply the patch and clear your browser cache. View the
detail page for a bibliographic record in the staff client. Click the
link to show the MARC preview. Confirm that the modal looks correct,
works correctly, and adapts gracefully to different browser widths.

Confirm that the MARC preview and Card links still work from Z39.50
searches.

Note: This patch assumes that UNIMARC records display correctly using
xslt/plainMARC.xsl. Please let me know if that is wrong.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

I confirm it works: nice modal dialog box; display aligned on opac display;
works also with Unimarc biblios.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2014-11-21 18:33:27 UTC
Patch pushed to master.

Thanks Owen!