The new code for facets calculation could probably be more precise for unimarc (in biblio-koha-indexdefs.xml) - for series, 410 tag is probably better than 225 - the date and place subdivisions 6XX$y and 6XX$z could be indexed (in su-geo and su-chrono) - the subdivisionn $x is indexed for 606, but all 6XX$x could also be indexed (in su-to) - 5XX are not subjects, so I'm not sure that indexing them in su-ut is good (but we should check in ccl.properties how this index is defined). Anyway, I always found that indexing 5XX was a weird idea... and there is maybe a mistake for 995$b - holdingbranch (should be 995$c) M. Saby
Created attachment 33132 [details] [review] Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework.
Hello A change is also needed in biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xml Mathieu
Created attachment 33135 [details] [review] Bug 13157 UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework.
Could soomeone give this a sign-off please?
I was about to sign it off, but comparing to the current frameworks I wasn't sure: ('995', 'a', 'Fournisseur', '', 0, 0, 'items.booksellerid', -1, '', '', '', 0, 0, '', NULL, '', ''), ('995', 'b', 'Site Propriétaire', '', 0, 1, 'items.homebranch', 10, 'branches',... ('995', 'c', 'Site Dépositaire', '', 0, 1, 'items.holdingbranch', 10, 'branches',... So maybe a followup is needed too.
Created attachment 33825 [details] [review] [SIGNED OFF] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 33826 [details] [review] [SIGNED OFF] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Please feel free to obsolete my followup if you think it is wrong. But in that case please check installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql and fill a new bug for it.
(In reply to Tomás Cohen Arazi from comment #8) > Please feel free to obsolete my followup if you think it is wrong. But in > that case please check > > installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/ > framework_DEFAULT.sql > > and fill a new bug for it. No, your followup is correct! and required. Mine was incomplete.
Created attachment 33878 [details] [review] [PASSED QA] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 33879 [details] [review] [PASSED QA] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Frederic!