Bug 13161 - Report name should be mandatory when editing saved reports
Summary: Report name should be mandatory when editing saved reports
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 16:56 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13161 - Report name should be mandatory when editing saved reports (4.74 KB, patch)
2014-10-29 17:43 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13161 - Report name should be mandatory when editing saved reports (4.76 KB, patch)
2014-10-29 17:57 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 13161 - Report name should be mandatory when editing saved reports (4.86 KB, patch)
2014-10-30 00:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 13161 - Report name should be mandatory when editing saved reports (4.86 KB, patch)
2014-10-30 00:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-29 16:56:42 UTC
Bug 2969 made report name mandatory for new reports but failed to do the same when editing existing reports.
Comment 1 Owen Leonard 2014-10-29 17:43:02 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2014-10-29 17:57:50 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-30 00:21:50 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-10-30 00:22:10 UTC
Created attachment 32957 [details] [review]
[PASSED QA] Bug 13161 - Report name should be mandatory when editing saved reports

When Bug 2969 made report name required for SQL reports, it did so only
for new reports. This patch makes the same requirement true when editing
existing reports.

Other changes:

- Removed unused "type" setting from edit screen (already removed from
  creation form).
- Added form field size attribute to report name field to match creation
  form.
- Moved SQL textarea into its own fieldset and marked it as required,
  matching the report creation form.

To test, apply the patch and edit an existing saved SQL report. You
should be prevented from saving your report with either the report name
or SQL field blank. Test with JavaScript enable and disabled.

Confirm that after entering valid data your report runs correctly.
Compare the new SQL report form with the update SQL report form. They
should be structured the same.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script. Works as described.
Comment 5 Tomás Cohen Arazi 2014-10-30 04:01:39 UTC
Patch pushed to master.

Thanks Owen!