Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled
Summary: Circulation page layout problem when OnSiteCheckoutsForce is enabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 10860 13183
Blocks: 13184
  Show dependency treegraph
 
Reported: 2014-10-31 13:53 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled (2.33 KB, patch)
2014-10-31 15:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled (2.36 KB, patch)
2014-10-31 17:20 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[PASSED QA] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled (2.47 KB, patch)
2014-10-31 20:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-31 13:53:40 UTC
If you have OnSiteCheckoutsForce enabled and try to check out to a patron who is blocked from checking out the layout is awkward. The page structure needs to correctly handle a two-column layout in this case as well as the layout required when OnSiteCheckoutsForce is off.
Comment 1 Owen Leonard 2014-10-31 15:58:14 UTC Comment hidden (obsolete)
Comment 2 Brendan Gallagher 2014-10-31 17:20:30 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-31 20:00:26 UTC
Created attachment 33112 [details] [review]
[PASSED QA] Bug 13179 - Circulation page layout problem when OnSiteCheckoutsForce is enabled

The circulation page layout needs to work correctly for various
combinations of restrictions, no restrictions, and restrictions with
OnSiteCheckoutsForce enabled. This patch makes some minor accomodation
for all.

To test, load a patron for checkout under the following conditions:

1. OnSiteCheckoutsForce and patron is not blocked from checkout
2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for
   being expired or restricted).
3. OnSiteCheckoutsForce is on and patron is not blocked from checkout
4. OnSiteCheckoutsForce is on and patron is blocked from checkout

The page layout should look correct for all these cases, with a clean
two-column layout of [ checkout form | messages ] in all cases except

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Applied on top of 10860. Works as described.
Comment 4 Tomás Cohen Arazi 2014-11-03 16:30:13 UTC
Patch pushed to master.

Thanks Owen!