Bug 13227 - Display856uAsImage displays images in OPAC in original size
Summary: Display856uAsImage displays images in OPAC in original size
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-09 21:34 UTC by Katrin Fischer
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13227: Display856uAsImage displays images in OPAC in original size (6.07 KB, patch)
2014-11-09 21:36 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 13227: Display856uAsImage displays images in OPAC in original size (6.12 KB, patch)
2014-11-10 05:38 UTC, Chris Cormack
Details | Diff | Splinter Review
[Passed QA] Bug 13227: Display856uAsImage displays images in OPAC in original size (6.21 KB, patch)
2014-11-12 07:53 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-11-09 21:34:13 UTC
To test:
- catalog a record with 856$u = URL to an image, $q = img
- turn on the system preference Display856uAsImage
- make sure your record has been reindexed by Zebra
- verifiy the image indeed displays on the result and detail page
  in the bootstrap catalog.

The image shows in the original size, from the code it's meant to display with a height of 100 px, but this won't work in bootstrap as the height is set to auto with CSS.
Comment 1 Katrin Fischer 2014-11-09 21:36:41 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-11-10 05:38:07 UTC Comment hidden (obsolete)
Comment 3 Martin Renvoize 2014-11-12 07:53:30 UTC
Created attachment 33470 [details] [review]
[Passed QA] Bug 13227: Display856uAsImage displays images in OPAC in original size

To test:
- catalog a record with 856$u = URL to an image, $q = img
- turn on the system preference Display856uAsImage
- make sure your record has been reindexed by Zebra
- verifiy the image indeed displays on the result and detail page
  in the bootstrap catalog.

The image shows in the original size, from the code it's meant
to display with a height of 100 px, but this won't work in bootstrap
as the height is set to auto with CSS.

Patch changes the XSLT to restore the former behaviour.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2014-11-12 07:53:56 UTC
Passes all my tests and qa script. Passing QA
Comment 5 Tomás Cohen Arazi 2014-11-17 00:09:41 UTC
Patch pushed to master.

Thanks Katrin!