Bug 13229 - Suggestion date filters have a style problem
Summary: Suggestion date filters have a style problem
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-10 22:18 UTC by Katrin Fischer
Modified: 2015-09-17 19:55 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Screenshot (20.30 KB, image/png)
2014-11-10 22:18 UTC, Katrin Fischer
Details
Bug 13229 - Suggestion date filters have a style problem (6.40 KB, patch)
2014-11-11 13:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13229 - Suggestion date filters have a style problem (6.41 KB, patch)
2014-11-11 15:42 UTC, Blou
Details | Diff | Splinter Review
[PASSED QA] Bug 13229 - Suggestion date filters have a style problem (6.51 KB, patch)
2014-11-12 07:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-11-10 22:18:44 UTC
Created attachment 33444 [details]
Screenshot

The date related filters on the suggestion page don't look quite right/as before.
Comment 1 Owen Leonard 2014-11-11 13:53:03 UTC Comment hidden (obsolete)
Comment 2 Blou 2014-11-11 15:42:28 UTC Comment hidden (obsolete)
Comment 3 Blou 2014-11-11 15:43:53 UTC
Looks good on Firefox 28, at least.
Comment 4 Blou 2014-11-11 15:44:16 UTC
Looks good on Firefox 28, at least.
Comment 5 Katrin Fischer 2014-11-12 07:09:52 UTC
Created attachment 33466 [details] [review]
[PASSED QA] Bug 13229 - Suggestion date filters have a style problem

The suggestion date filters appear to be picking up a style change which
wasn't anticipated for the suggestions page markup. This patch solves
the problem by simplifying and standardizing the markup, including
simplifications to the label structure.

To test, apply the patch and view the suggestions management page in the
staff client. Expand the "suggestion information" filter section and
confirm that the label/input structure looks correct and works
correctly.

Signed-off-by: Blou <philippe.blouin@inlibro.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, looking better.
Comment 6 Tomás Cohen Arazi (tcohen) 2014-11-20 12:59:15 UTC
Patch pushed to master.

Thanks Owen!