Bug 13231 - ISBD/AACR2 punctuation causes double facets
Summary: ISBD/AACR2 punctuation causes double facets
Status: RESOLVED DUPLICATE of bug 17661
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-11 10:14 UTC by paxed
Modified: 2019-04-25 05:38 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Naively remove ISBD punctuation from facets (1.02 KB, patch)
2014-11-11 10:14 UTC, paxed
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13231: ISBD/AACR2 punctuation causes double facets (1.86 KB, patch)
2015-05-29 19:14 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-11-11 10:14:18 UTC Comment hidden (obsolete)
Comment 1 Katrin Fischer 2014-12-06 09:15:50 UTC
I think the former facet code removed the punctuation at the end and did some other tricks.
Comment 2 Marc Véron 2015-05-18 14:50:58 UTC
I could reproduce the double facets following the test plan.

Howver, the patch did not apply on current master, I got:

Apply? [(y)es, (n)o, (i)nteractive] y

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2630, in <module>
    do_apply(*args)
  File "/usr/local/bin/git-bz", line 1755, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users']
  File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1312, in single_request
    response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>
Comment 3 Tomás Cohen Arazi 2015-05-18 14:54:45 UTC
(In reply to Marc Véron from comment #2)
>
> xmlrpclib.ProtocolError: <ProtocolError for
> bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>

That looks like a networking issue
Comment 4 Marc Véron 2015-05-18 15:31:24 UTC
I tried with other bugs / patches, no problem to apply, only with this one.
Comment 5 Katrin Fischer 2015-05-18 20:09:04 UTC
It looks like the patch file is missing a few lines at the top - might need to be redone. I have the same error as Marc.
Comment 6 Bernardo Gonzalez Kriegel 2015-05-29 19:14:18 UTC
Created attachment 39704 [details] [review]
[SIGNED-OFF] Bug 13231: ISBD/AACR2 punctuation causes double facets

(Reworked patch, original from paxed was a diff file)

Naively remove ISBD punctuation from facets

Using MARC21, assume the following in one biblio:
  100 1 $aFoo, $ewriter.
And this in another biblio:
  100 1 $aFoo.

This produces double facets, one of "Foo,"
and another for "Foo." -
It should just use one facet, "Foo"

Attached is a quick hack to achieve this.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Test:
2 records modified as proposed, search by author gives 2 facets
With patch only one
No errors
Comment 7 Katrin Fischer 2015-05-31 13:04:21 UTC
Thx Bernardo!
Comment 8 Katrin Fischer 2015-05-31 20:45:47 UTC
Hm, 2 things here: I think the described case can only happen when not using authorities as there seems no way to include ISBD punctuation at the end when you do.

The other thing is more serious: With displayFacetCount turned ON, the number of facets shown with the patch is wrong.
Comment 9 Joonas Kylmälä 2015-08-21 11:15:58 UTC
(In reply to Katrin Fischer from comment #8)
> Hm, 2 things here: I think the described case can only happen when not using
> authorities as there seems no way to include ISBD punctuation at the end
> when you do.

No way to include ISBD punctuation when adding/changing authorities? What do you mean?
Comment 10 Katrin Fischer 2015-08-23 20:05:52 UTC
In testing I found it impossible to add . or similar to a heading linked to an authority record - but I just added that note here for documentation. So it would be easier for others to test.
Comment 11 Marjorie Barry-Vila 2019-04-24 19:43:57 UTC
Hi,
Is it a duplicate of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 ?

Marjorie
Comment 12 Katrin Fischer 2019-04-25 05:38:21 UTC
Marking this a duplicate of the older bug 17661, because there are more people on CC list there. Not sure if the patch here could be rescued?

*** This bug has been marked as a duplicate of bug 17661 ***