Created attachment 33454 [details] [review] Naively remove ISBD punctuation from facets Using MARC21, assume the following in one biblio: 100 1 $aFoo, $ewriter. And this in another biblio: 100 1 $aFoo. This produces double facets, one of "Foo," and another for "Foo." - It should just use one facet, "Foo" Attached is a quick hack to achieve this.
I think the former facet code removed the punctuation at the end and did some other tricks.
I could reproduce the double facets following the test plan. Howver, the patch did not apply on current master, I got: Apply? [(y)es, (n)o, (i)nteractive] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2630, in <module> do_apply(*args) File "/usr/local/bin/git-bz", line 1755, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1578, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1312, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>
(In reply to Marc Véron from comment #2) > > xmlrpclib.ProtocolError: <ProtocolError for > bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> That looks like a networking issue
I tried with other bugs / patches, no problem to apply, only with this one.
It looks like the patch file is missing a few lines at the top - might need to be redone. I have the same error as Marc.
Created attachment 39704 [details] [review] [SIGNED-OFF] Bug 13231: ISBD/AACR2 punctuation causes double facets (Reworked patch, original from paxed was a diff file) Naively remove ISBD punctuation from facets Using MARC21, assume the following in one biblio: 100 1 $aFoo, $ewriter. And this in another biblio: 100 1 $aFoo. This produces double facets, one of "Foo," and another for "Foo." - It should just use one facet, "Foo" Attached is a quick hack to achieve this. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test: 2 records modified as proposed, search by author gives 2 facets With patch only one No errors
Thx Bernardo!
Hm, 2 things here: I think the described case can only happen when not using authorities as there seems no way to include ISBD punctuation at the end when you do. The other thing is more serious: With displayFacetCount turned ON, the number of facets shown with the patch is wrong.
(In reply to Katrin Fischer from comment #8) > Hm, 2 things here: I think the described case can only happen when not using > authorities as there seems no way to include ISBD punctuation at the end > when you do. No way to include ISBD punctuation when adding/changing authorities? What do you mean?
In testing I found it impossible to add . or similar to a heading linked to an authority record - but I just added that note here for documentation. So it would be easier for others to test.
Hi, Is it a duplicate of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 ? Marjorie
Marking this a duplicate of the older bug 17661, because there are more people on CC list there. Not sure if the patch here could be rescued? *** This bug has been marked as a duplicate of bug 17661 ***