Bug 10153 changed the layout of the patron search form so that expanded search fields would be stacked (http://www.screencast.com/t/LnVgH2nV) rather than in one line (http://www.screencast.com/t/t0XkqsSX). Bug 9811 returned the layout to a non-stacked layout (http://www.screencast.com/t/9Cn8B0VKm6q), but I think this was not done as an intentional override of Bug 10153. I think the patch was based on the previous version. I propose to bring back the stacked version.
I liked the non-stacked, especially since German words are often longer than the english ones and the stacked layout gives more flexiblity.
Created attachment 33502 [details] [review] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly.
(In reply to Owen Leonard from comment #0) > Bug 9811 returned the layout to a non-stacked layout > (http://www.screencast.com/t/9Cn8B0VKm6q), but I think this was not done as > an intentional override of Bug 10153. I think the patch was based on the > previous version. Yes completely, sorry about that. (In reply to Katrin Fischer from comment #1) > I liked the non-stacked, especially since German words are often longer than > the english ones and the stacked layout gives more flexiblity. So you prefer the stacked or the non-stacked version? :) Could you rebase this patch please?
Ah right, the stacked! Every option on its own line :)
Created attachment 34073 [details] [review] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly.
Created attachment 34084 [details] [review] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 34085 [details] [review] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 34153 [details] [review] [PASSED QA] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34154 [details] [review] [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Please rebase!
Created attachment 35472 [details] [review] [PASSED QA] [Rebased] Bug 13235 - Revise layout of patron search form Bug 9811 (Patron search improvements) reversed the layout changes made by Bug 10153. This patch returns to the form to its "stacked" layout. To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Note: This patch contains indentation changes, so please diff accordingly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 35473 [details] [review] [PASSED QA] Bug 13235: Move onclick attr to javacsript code Refactor 1 line of code and add a preventDefault. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I have rebased my patch and re-attached the follow-up so that they are in the right order.
Patches pushed to master. Thanks Owen!
Hmm this doesnt apply on 3.18.x .. if you think it should be on there, could you please rebase it for that. Thanks