The DataTables sDom configuration for the new AJAX circulation checkouts table contains some superfluous markup which pushes the checkouts table down. This distance can mean the difference, on some screens, between being able to see the last item checked out or not.
Created attachment 33543 [details] [review] Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides.
Created attachment 33544 [details] [review] Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked per plan on both Check Out and Details pages, spacing appears correct.
Created attachment 33545 [details] [review] [PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation On the new checkouts page there is some padding above the checkouts, relatives' checkouts, and holds tables caused by extra markup in the table's sDom configuration (http://legacy.datatables.net/ref#sDom): <'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t This creates several empty <div>s which don't serve any purpose. This patch simplifies it to: rt To test, apply the patch, clear your browser cache, and check out to a patron who has items checked out, holds on their account, and child records attached which also have checkouts. The padding above the table of checkouts, the table of relatives' checkouts, and the table of holds should match that on the sides. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked per plan on both Check Out and Details pages, spacing appears correct. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found.
Patch pushed to master. Thanks Owen!
Pushed to 3.16.x, patch will be in 3.16.7