t/Search.t should mock the DB
Created attachment 33635 [details] [review] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards
Created attachment 33642 [details] [review] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Turned off MySQL and ran the tests before and after the patch. Works as advertised.
Created attachment 33697 [details] [review] [PASSED QA] Bug 13278: t/Search.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Search.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Search.t => SUCCESS: tests pass because the ycan be loaded regardless of the absence of the DB server - Sign off :-D Regards Signed-off-by: Magnus Enger <digitalutvikling@gmail.com> Turned off MySQL and ran the tests before and after the patch. Works as advertised. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 33713 [details] [review] Bug 13278: (QA followup) use t::lib::Mocks Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master.