Bug 13281 - t/ImportBatch.t shouldn't depend on the DB
Summary: t/ImportBatch.t shouldn't depend on the DB
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks: 13275
  Show dependency treegraph
 
Reported: 2014-11-18 08:12 UTC by Magnus Enger
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13281: t/ImportBatch.t shouldn't depend on the DB (1.46 KB, patch)
2014-11-19 21:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 13281: t/ImportBatch.t shouldn't depend on the DB (1.50 KB, patch)
2014-11-20 00:34 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 13281: t/ImportBatch.t shouldn't depend on the DB (1.57 KB, patch)
2014-11-20 09:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2014-11-18 08:12:23 UTC
With MySQL turned off:

$ sudo -u kohadev-koha KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml prove t/ImportBatch.t
t/ImportBatch.t .. DBI connect('dbname=koha_kohadev;host=localhost;port=3306','koha_kohadev',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at C4/Context.pm line 785
t/ImportBatch.t .. 1/1 
#   Failed test 'use C4::ImportBatch;'
#   at t/ImportBatch.t line 12.
#     Tried to use 'C4::ImportBatch'.
#     Error:  Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at C4/Context.pm line 785.
# Compilation failed in require at C4/Search.pm line 28.
# BEGIN failed--compilation aborted at C4/Search.pm line 28.
# Compilation failed in require at C4/AuthoritiesMarc.pm line 24.
# BEGIN failed--compilation aborted at C4/AuthoritiesMarc.pm line 24.
# Compilation failed in require at C4/ImportBatch.pm line 28.
# BEGIN failed--compilation aborted at C4/ImportBatch.pm line 28.
# Compilation failed in require at t/ImportBatch.t line 12.
# BEGIN failed--compilation aborted at t/ImportBatch.t line 12.
# Looks like you failed 1 test of 1.
t/ImportBatch.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/ImportBatch.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=1,  3 wallclock secs ( 0.02 usr  0.01 sys +  0.58 cusr  0.65 csys =  1.26 CPU)
Result: FAIL
Comment 1 Tomás Cohen Arazi 2014-11-19 21:07:57 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2014-11-20 00:34:31 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-11-20 09:57:05 UTC
Created attachment 33734 [details] [review]
Bug 13281: t/ImportBatch.t shouldn't depend on the DB

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Tomás Cohen Arazi 2014-11-20 12:58:30 UTC
Patch pushed to master.