I think this is probably a rare case but when running updatedatabase the switch from ccsr or prog to bootstrap assumes that opacthemes has an existing value. If its not defined the update process reports two errors for the two comparisons. Add a check for definedness and if not set default to 'bootstrap' ( A value other than prog or ccsr should be preserved as was the initial intention )
Created attachment 33652 [details] [review] Proposed patch
Created attachment 34622 [details] [review] Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Bit worried, if opacthemes is not defined, should we point this out as a possible problem?
I misread - the value will be set.
Created attachment 34697 [details] [review] [PASSED QA] Bug 13285 Do the right thing if opacthemes is not set If opacthemes is not defined updatedatabase reports the subsequent warnings as an error. Take account of the case where it is not set and default that to bootstrap. This is probably a rare occurence, but should be handled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Good catch Colin!
Pushed to 3.18.x will be in 3.18.3
Contains DB changes, passing for 3.16.x