The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document.
Should be easy enough to work around. We found a way to get at stuff on the check out table with jQuery.
Created attachment 33676 [details] [review] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform.
Please check the behavior in 3.14.x. The purpose of the "Override renewal limit" option to allow the librarian (if AllowRenewalLimitOverride is enabled) to renew items even after the patron has exceeded the renewal limit. With this patch I can see the checkboxes, but I can't select them because they are disabled.
This is a major problem - please fix with high priority.
Created attachment 33787 [details] [review] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform.
Created attachment 33803 [details] [review] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution.
Created attachment 33805 [details] [review] [PASSED QA] Bug 13293 - Regression: Override renewal limit option broken with AJAX circ The "Override renewal limit" checkbox no longer works to un-hide the renewal checkboxes in the table of checkouts. I assume this is because the script works in such a way that it is looking for the checkboxes before they are part of the document. Test Plan: 1) Apply this patch 2) Check the "Override renewal limit" checkbox 3) Note the checkbox now appears Note, this change allows the "X of Y renewals remaining" to be displayed for non-renewable items. I left this as it is for two reasons: 1) it gives the librarian more information that may be useful, and 2) it looks nicer and more uniform. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, works as described. Exception: on-site checkouts can't be renewed.
Patch pushed to master. Thanks Kyle!
Pushed to 3.16.x, patch will be in 3.16.7