Bug 13297 - Shelving location PROC does not work according to manual
Summary: Shelving location PROC does not work according to manual
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 13:13 UTC by Kyle M Hall
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13297 - Shelving location PROC does not work according to manual (4.26 KB, patch)
2014-11-19 13:16 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 13297 - Shelving location PROC does not work according to manual (4.67 KB, patch)
2014-11-20 15:51 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 13297 - Shelving location PROC does not work according to manual (4.73 KB, patch)
2014-11-20 20:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-11-19 13:13:30 UTC
According to the manual, "Items will stay in the PROC location until they are checked in" ( http://manual.koha-community.org/3.18/en/processinglocations.html ). 

This is not the actual behavior. Right now items will only change from PROC to CART, and that is only if InProcessingToShelvingCart is enabled. Some libraries want to use the PROC to permanent location feature, without using the CART. 

Additionally, the location is only removed if using returns.pl, but that is not what the manual says either. What if the library uses SIP2 devices for handling returns? This should be taken into account.
Comment 1 Kyle M Hall 2014-11-19 13:16:26 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-11-20 15:51:13 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-11-20 16:15:17 UTC
Note that because of Bug 13311 you can't test this patch properly if you are adding items but you're not selecting an existing shelving location. If you leave it blank you'll trigger Bug 13311. Test by choosing an existing shelving location or by manually updating the item record in MySQL to set a NULL or blank value.
Comment 4 Katrin Fischer 2014-11-20 20:07:12 UTC
Created attachment 33767 [details] [review]
[PASSED QA] Bug 13297 - Shelving location PROC does not work according to manual

According to the manual, "Items will stay in the PROC location until
they are checked in".

This is not the actual behavior. Right now items will only change from
PROC to CART, and that is only if InProcessingToShelvingCart is enabled.
Some libraries want to use the PROC to permanent location feature,
without using the CART.

Additionally, the location is only removed if using returns.pl, but
that is not what the manual says either. What if the library uses
SIP2 devices for handling returns? This should be taken into
account.

Test Plan:
1) Apply this patch
2) Set an item's current location to PROC, and it's permananet location
   to a different location.
3) Check the item in any way you wish
4) Note the shelving location is updated to the permanent location
5) prove t/db_dependent/Circulation/Returns.t

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I tested this with items which had items.location set to 'PROC' and
items.permanent_location set to NULL, '', and a real value, and it
worked correctly in all cases. I tested with check-ins from returns.pl
and from the table of checkouts in circulation and the PROC location was
correctly removed in both cases.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Comment 5 Tomás Cohen Arazi 2014-11-23 13:24:20 UTC
Patch pushed to master.

Thanks Kyle!