Bug 13302 - Use CSS3 ellipsis for email address in staff client patron sidebar
Summary: Use CSS3 ellipsis for email address in staff client patron sidebar
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-19 19:26 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13302 - Use CSS3 ellipsis for email address in staff client patron sidebar (2.13 KB, patch)
2014-11-19 19:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot (18.85 KB, image/png)
2014-11-19 20:44 UTC, Mirko Tietgen
Details
Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar (5.63 KB, patch)
2016-02-01 14:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar (5.73 KB, patch)
2016-02-02 12:26 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar (5.81 KB, patch)
2016-02-03 12:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-11-19 19:26:18 UTC
The solution which fixed Bug 3256 back in 2009 can be replaced with a more modern CSS3 technique.
Comment 1 Owen Leonard 2014-11-19 19:38:30 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2014-11-19 20:44:47 UTC
Created attachment 33701 [details]
Screenshot

Works for me on circulation.pl, but does not work on moremember.pl, see attached sceenshot.
Comment 3 Mirko Tietgen 2014-11-19 20:50:04 UTC
(Well, the ellipsis works but it seems a little off. Links are OK. No ellipsis for the address displayed in the center of moremember.pl, with or without the patch)
Comment 4 Owen Leonard 2016-02-01 14:51:27 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2016-02-02 12:26:16 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-02-03 12:20:06 UTC
Created attachment 47576 [details] [review]
Bug 13302 [Revised] Use CSS3 ellipsis for email address in staff client patron sidebar

This patch replaces the email address text overflow solution implemented
by Bug 3256 with a CSS3 technique: text-overflow: ellipsis

https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow

To test, apply the patch and clear your browser cache. Edit the primary
email address of a patron so that it is very long. View that patron in
the staff client (on the checkout or details page, for instance) and
confirm that the email address is truncated with "..."

Confirm that the link and the title attribute of the link contain the
correct, full email address.

Revision uses a percentage instead of a fixed width for email display in
the sidebar to accommodate varying sidebar widths. Also added: Handling
of all email addresses displayed on the patron detail page. Although
email addresses in the body of that page were not in the scope of the
original patch, it's a good improvement to include those as well.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Brendan Gallagher 2016-03-02 04:59:41 UTC
Pushed to Master - Should be in the May 2016 Release