13318 – C4::Acq::GetParcel is not used and can be removed

Bug 13318 - C4::Acq::GetParcel is not used and can be removed

Summary: C4::Acq::GetParcel is not used and can be removed

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Testopia

URL:
Keywords:

Depends on:	12826
Blocks:
	Show dependency tree / graph

Reported:	2014-11-21 10:48 UTC by Jonathan Druart
Modified:	2016-06-21 21:36 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 13318: Delete C4::Acq::GetParcel (3.46 KB, patch) 2014-11-21 10:53 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug-13318-Delete-C4-Acq-GetParcel.patch (3.53 KB, patch) 2014-11-28 05:48 UTC, wajasu	Details \| Diff \| Splinter Review
[PASSED QA] Bug 13318: Delete C4::Acq::GetParcel (3.58 KB, patch) 2014-12-05 15:10 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2014-11-21 10:48:14 UTC

The subroutine C4::Acquisition::GetParcel is never used in the code.
It can be removed.

Comment 1 Jonathan Druart 2014-11-21 10:53:22 UTC Comment hidden (obsolete)

Created attachment 33774 [details] [review]
Bug 13318: Delete C4::Acq::GetParcel

Test plan:
  git grep GetParcel
should not return use of this subroutine.

Comment 2 wajasu 2014-11-28 05:48:45 UTC Comment hidden (obsolete)

Created attachment 34011 [details] [review]
Bug-13318-Delete-C4-Acq-GetParcel.patch

Reviewed code.

# before patch
git grep GetParcel
C4/Acquisition.pm:        &GetParcels &GetParcel
C4/Acquisition.pm:=head3 GetParcel
C4/Acquisition.pm:  @results = &GetParcel($booksellerid, $code, $date);
C4/Acquisition.pm:sub GetParcel {
C4/Acquisition.pm:=head3 GetParcels
C4/Acquisition.pm:  $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto);
C4/Acquisition.pm:sub GetParcels {

#after patch
git grep GetParcel
C4/Acquisition.pm:        &GetParcels
C4/Acquisition.pm:=head3 GetParcels
C4/Acquisition.pm:  $results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto);
C4/Acquisition.pm:sub GetParcels {


Dead code removed.

Comment 3 Kyle M Hall (khall) 2014-12-05 15:10:27 UTC

Created attachment 34150 [details] [review]
[PASSED QA] Bug 13318: Delete C4::Acq::GetParcel

Test plan:
  git grep GetParcel
should not return use of this subroutine.

Signed-off-by: wajasu <matted@34813.mypacks.net>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 4 Tomás Cohen Arazi (tcohen) 2015-01-10 19:19:58 UTC

Patch pushed to master.

Thanks Jonathan!