If you try to create a new suggestion from OPAC and AllowPurchaseSuggestionBranchChoice is turned on, it will result in a perl error: DBIx::Class::Row::new(): No such column 'branch' on Koha::Schema::Result::Suggestion at /home/katrin/kohaclone/C4/Suggestions.pm line 449
Created attachment 33830 [details] [review] Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error.
Created attachment 33854 [details] [review] Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 33877 [details] [review] [PASSED QA] Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, thx for the quick fix.
Yay team! That was lightning fast!
Patch pushed to master. Thanks Jonathan!