Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group').
Created attachment 33894 [details] [review] Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled.
It could be good to have this fix for the 3.18 release.
Created attachment 34069 [details] [review] Bug 13333: Fix Display basket group for already received orders I've applied the patch. Everything is OK on parcel.pl, as required. So I pass the patch to "Signed Off" status. NB. For an already received order, the basket group is generally closed [it can be reopened after]. The current link now available from the BG's name is: ./koha/acqui/basketgroup.pl?booksellerid=10 which shows the list of the vendor's BGs, whose default tag is the "Open" BGs. On the contrary, if the link now available from the BG's name would be set to: ./koha/acqui/basketgroup.pl?op=add&booksellerid=10&basketgroupid=5 ./koha/acqui/basketgroup.pl?op=add&booksellerid=10&basketgroupid=5 the user could look at the BG at once, closed or open.
Created attachment 34152 [details] [review] [PASSED QA] Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
It is not applying on master, could you please rebase?
Created attachment 35439 [details] [review] Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.4
(In reply to Chris Cormack from comment #8) > Pushed to 3.18.x will be in 3.18.4 Pushed to 3.16.x, will be in 3.16.8