When a basket/shelf is downloaded, items are embedded, but not when sending it by email. This seems to be a bug, we would expect to get the same file.
Set component to "architecture", the bug is on both interfaces (opac and intranet) and for baskets and shelves.
Created attachment 33952 [details] [review] B Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items.
Created attachment 34623 [details] [review] Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34708 [details] [review] [PASSED QA] Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
A note about this: as things currently are, we will send out information that has been marked as not visible in the OPAC or labelled as internal note. I wonder if we should make including items in the staff/cart optional for the time being as fixing the problem with visibility is a much bigger issue. There has been a discussion about this for OAI as well, but things OPAC side might need a different treatment (bug 12252). I know this patch just makes things more consistent as one download includes items and the other does not - if people are ok with the idea of optional, I will try to work up a patch on a separate bug - not blocking this.
yes, we should at least call GetMarcBiblio with the 3rd param set to 1 (opac=1). It is introduced by bug 12252.
The opac=1 flag will remove items hidden with opachiddenitems - so it would be really good to add that here.
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.4
Pushed to 3.16.x, will be in 3.16.8r
(In reply to Katrin Fischer from comment #5) > A note about this: as things currently are, we will send out information > that has been marked as not visible in the OPAC or labelled as internal > note. I wonder if we should make including items in the staff/cart optional > for the time being as fixing the problem with visibility is a much bigger > issue. > There has been a discussion about this for OAI as well, but things OPAC side > might need a different treatment (bug 12252). > > I know this patch just makes things more consistent as one download includes > items and the other does not - if people are ok with the idea of optional, I > will try to work up a patch on a separate bug - not blocking this. I'd still like to see this, Koha should be the most privacy conscious library system out there. Let's try to make this our goal. I'd be happy to test and sign off a patch that respects the hidden settings