To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)">
Created attachment 33993 [details] [review] Bug 13355: System preferences tab value wrong in templates This patch fixes a bug on the system preferences tab templates. To test: To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)"> - Apply the patch - Repeat (1) and (2) => SUCCESS: you will see below the form tag something like: <input type="hidden" name="tab" value="enhanced_content"> and <input type="hidden" name="tab" value="opac"> respectively. - Sign off :-D Regards
Created attachment 34005 [details] [review] [SIGNED-OFF] Bug 13355 System preferences tab value wrong in template Used view source to inspect before and after patch. It works!
Created attachment 34006 [details] [review] [SIGNED-OFF] Bug 13355: System preferences tab value wrong in templates Patched worked.
Created attachment 34149 [details] [review] [PASSED QA] Bug 13355: System preferences tab value wrong in templates This patch fixes a bug on the system preferences tab templates. To test: To reproduce: (1) - Choose a tab on the sysprefs section (for example 'Enhanced Content') - Right click on 'Enhanced Content preferences' title, and choose to 'inspect' the code => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value=""> (2) - Do a syspref search (for example 'facet'). - Right click on one of the category titles (for example 'OPAC preferences') => FAIL: you will see below the form tag something like: <input type="hidden" name="op" value="save"> <input type="hidden" name="tab" value="HASH(0x6e53050)"> - Apply the patch - Repeat (1) and (2) => SUCCESS: you will see below the form tag something like: <input type="hidden" name="tab" value="enhanced_content"> and <input type="hidden" name="tab" value="opac"> respectively. - Sign off :-D Regards Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master.
Pushed to 3.18.x will be 3.18.2