A TT block construct on itemsearch.tt makes impossible to translate some strings
To clarify, these label strings are not picked up by the translation toolchain: [% INCLUDE form_field_select_option value='barcode' label='Barcode' %] Perhaps the TT should have a dummy _() marker function, similar to javascript.
(In reply to paxed from comment #1) > To clarify, these label strings are not picked up by the translation > toolchain: > [% INCLUDE form_field_select_option value='barcode' label='Barcode' %] > > Perhaps the TT should have a dummy _() marker function, similar to > javascript. Perhaps that could be the best solution. For now I will add a TT block with all labels to translate.
Created attachment 34015 [details] [review] Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes"
Created attachment 34666 [details] [review] [Signed-off] Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 34681 [details] [review] Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Great improvement! All looks good. Marked as Passed QA.
Patch pushed to master. Thanks Bernardo!
Pushed to 3.18.x will be in 3.18.3
Contains string changes, holding for 3.16.8
Hi Mason, item search is new in 3.18, so you should not need this :)