If you try to export a record with several 650 fields (for instance), the KW lines won't be displayed in the fields order.
Created attachment 34012 [details] [review] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order.
Created attachment 34742 [details] [review] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment.
Created attachment 34761 [details] [review] [PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW This patch only fixes the KW order. Test plan: 1/ Choose/create a record with several 6XX (for KW), see the code source to know which fields you can use 2/ Export this record in RIS format 3/ Verify that the KW lines are ordered following the marc record fields order. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> We really should refactor this whole thing into Koha::RIS sometime, it's a horrible module at the moment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.3
Pushed to 3.16.x, patch will be in 3.16.7