When editing an item, the call number browser search for existing call number. If it shows a line is green between two call numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection.
Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Created attachment 34041 [details] [review] Add a call number browser in item edition page
To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose callnumber.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red.
I've applied the patch. Everything is OK until the 7-th step [included]. At 8) step, nothing happened. When my mouse is over the three points, I saw "Tag editor". I was on editing an already existent Y item for the X biblio: koha/cataloguing/additem.pl?op=edititem&biblionumber=X&itemnumber=Y#edititem&searchid=scs_1417518371030 So I pass the patch to "Failed QA" status.
Sorry Paola my bad, in 6) Choose cn_browser.pl not callnumber.pl as I wrote.
I've applied the patch (head 12123). Simith says: >in 6) Choose cn_browser.pl not callnumber.pl as I wrote. Thanks! So the "Call Numbers browser" pop-up has been opened as required. Choosing a full call number < MIN [or choosing a full call number > MAX], I saw no green row at the top of the table [or at the bottom of the table]. I think this is an error. So I pass the patch to "Failed QA" status. NB1. I've searched a value by the "Search call number:" input field, selecting "Search". I saw the error: An error has occurred! Error 404 This error means that the link was broken and that the page doesn't exist To report this error, you can email the Koha administrator. Use top menu bar to navigate to another part of Koha. NB2. In the Call numbers table : 10 has been listed before 2 10 has been listed before 1.
Created attachment 34108 [details] [review] fix patch - search call number does not work
Created attachment 34109 [details] [review] fix patch - searching call number < MIN or > MAX
Both problems (comment 6) should be corrected with the patches.
Preliminary QA comment: function Clic$function_name(i) { q = \$('[id^= \"tag_952_subfield_o\"]').val(); window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+q,\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\"); Please do not do it like that. Now you hardcoded the field while it is passed to you in a parameter. Also normally we pass index and value to the plugin in the URL. If you include your parameter i in the URL with something like index=i you can do this: var q=\$('#'+i).val(); window.open(... index="+i+"& ... ) And if you pass index via sub plugin to the template too, you can use it there if needed also. (In a popup you would use it when putting back the value in the field.) Also I am not sure what you are doing with the 'popup' parameter. You put it in the URL without a value. Later you are checking the value of popup. This is actually useless?
Created attachment 34476 [details] [review] sub plugin_javascript adjust
function function Clic$function_name(i) changed
Created attachment 34540 [details] [review] Bug 13364 - Add a call number browser in item edition page I've applied the patches against 3.19.00.000 head 13449 Everything is OK. I pass the patch to "Signed Off" status. NB: It has not been explicitly expressed by the usual sorting icons (2 vertical arrows), that the table was sortable selecting its 3 columns' titles: "Call Number", "Title", "Branch". So the user could miss that the resulting table was sortable. Anyway, if the user selected one of the 3 titles: - if the input value had been found (table with a red row with the shown value), the resulting sorted table was OK - otherwise, the green row lost its right position in the resulting sorted table.
Created attachment 34541 [details] [review] Bug 13364 - fix patch - search call number does not work
Created attachment 34542 [details] [review] Bug 13364 - fix patch - searching call number < MIN or > MAX
Created attachment 34543 [details] [review] Bug 13364 - sub plugin_javascript adjust
Created attachment 34586 [details] [review] [PASSED QA] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34587 [details] [review] [PASSED QA] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34588 [details] [review] [PASSED QA] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34589 [details] [review] [PASSED QA] Bug 13307 [QA Followup] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 35067 [details] [review] Bug 13364 - QA Followup
Kyle, Does this pass qa?
Note: The tablesorter jquery plugin has been removed from the src. Does not it possible to do the same thing using DataTables? +<table style="margin: auto;width:90%;" id="course_reserves"> => This is wrong
Hm, well spotted.
I asked Owen on IRC and he confirmed that we have removed the tablesorter plugin - I think we should avoid adding it back and having different implementations.
Created attachment 35549 [details] [review] Bug 13364 - fix tablesorter and squash When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose callnumber.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red.
Created attachment 36194 [details] [review] Bug 13364 - fix tablesorter and squash Easy conflict on the css file fixed.
I followed the test plan (comment #26) Selected callnumber.pl in step #6 -> did not work Selected cn_browser.pl in step #6 -> worked, shows Call Numbers browser Questions & remarks: 1) Is callnumber.pl obsolete? 2) Breadcrumb navigation and language selection appear in "Call number browser": I think this is not necessary in a popup window. 3) Capitalization of title? (Should be "Call numbers browser" instead of "Call Numbers browser")
Created attachment 36235 [details] [review] Bug 13364 - fix tablesorter and squash When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red.
Corrections : 1) Breadcrumb navigation and language selection removed; 2) Title changed ("Call numbers browser" instead of "Call Numbers browser"); 3) Test texte correction : 6) cn_browser.pl instead of callnumber.pl
Created attachment 36249 [details] [review] [Signed-off] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) OK tt_valid OK valid_template
Created attachment 36431 [details] [review] fix datatables.inc
QA corrected
Created attachment 36596 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
Created attachment 36597 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
Created attachment 36598 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
Created attachment 36599 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
Created attachment 36600 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
Created attachment 36601 [details] [review] Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass.
(Sorry about the spam with the first patch! Git bz was timing out and I didn't realize it was actually attaching the first patch...)
Comment on attachment 36600 [details] [review] Bug 13364 - Add a call number browser in item edition page Review of attachment 36600 [details] [review]: ----------------------------------------------------------------- Is there a good reason to have the template file in the tools directory, instead of cataloguing/value_builder? The green line is always at the top of the table. If I am remember correctly, in the previous version it was inserted correctly. ::: cataloguing/value_builder/cn_browser.pl @@ +1,4 @@ > +#!/usr/bin/perl > + > +use strict; > +use warnings; Prefer use Modern::Perl; @@ +9,5 @@ > +use C4::Output; > +use POSIX; > +use C4::ClassSource; > +use URI::Escape; > +use Data::Dumper; No needed. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt @@ +12,5 @@ > +<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> > +<script language="JavaScript"> > +$(document).ready(function() > +{ > + $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false}); Hum? Why did you choose this id?
Created attachment 36723 [details] [review] Bug 13364 - Add a call number browser in item edition page - QA fixed
Concerning #42 : Is there a good reason to have the template file in the tools directory, instead of cataloguing/value_builder? - No, Moved. The green line is always at the top of the table. If I am remember correctly, in the previous version it was inserted correctly. - Bug fixed ::: cataloguing/value_builder/cn_browser.pl @@ +1,4 @@ > +#!/usr/bin/perl > + > +use strict; > +use warnings; Prefer use Modern::Perl; - Fixed @@ +9,5 @@ > +use C4::Output; > +use POSIX; > +use C4::ClassSource; > +use URI::Escape; > +use Data::Dumper; No needed. - Fixed. use C4::ClassSource needed ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt @@ +12,5 @@ > +<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> > +<script language="JavaScript"> > +$(document).ready(function() > +{ > + $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false}); Hum? Why did you choose this id? - In intranet-tmpl/prog/en/css/staff-global.css there is "div#course_reserves_wrapper > table#course_reserves" needed to the table. So I just use it (do not change staff-global.css file).
(In reply to simith.doliveira from comment #44) > > + $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false}); > > Hum? Why did you choose this id? > > - In intranet-tmpl/prog/en/css/staff-global.css > there is "div#course_reserves_wrapper > table#course_reserves" needed to > the table. So I just use it (do not change staff-global.css file). Your last patch adds it.
(In reply to comment #45) - Your last patch adds it. Yep, you are right. I don't remember why I put "course_reserves", maybe I was working with other bz at the same time.
(In reply to simith.doliveira from comment #46) > (In reply to comment #45) > > - Your last patch adds it. > > Yep, you are right. I don't remember why I put "course_reserves", maybe I > was working with other bz at the same time. So please resubmit a patch with a correct id for this table.
Created attachment 36782 [details] [review] Bug 13364 - Add a call number browser in item edition page - QA fixed II
Created attachment 37192 [details] [review] [Signed-off] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37193 [details] [review] [Signed-off] Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37194 [details] [review] [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37195 [details] [review] [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed II Tested together with oter patches. Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 37195 [details] [review] [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed II Review of attachment 37195 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt @@ +34,4 @@ > </div> > <br /> > > +<table id="cn_browser_table"> Yes fine, but a previous patch changed the css file and you don't update it here...
I will submit a follow-up if it's ready.
Created attachment 38010 [details] [review] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - Add a call number browser in item edition page - QA fixed Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - Add a call number browser in item edition page - QA fixed II Tested together with oter patches. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 38011 [details] [review] Bug 13364: Fix table id + software error change table id in css file + C4::Output is used (Undefined subroutine CGI::output_html_with_http_headers) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I squashed the 4 patches (add + mv of the file in the same patch set) and perltidy on it. Marked as Passed QA.
Created attachment 38018 [details] [review] Bug 13364: Remove unused JS functions
Created attachment 38019 [details] [review] Bug 13364: Use SQL placeholder
Feature pushed to master. Thanks Simith!
Created attachment 38894 [details] [review] Bug 13364: (QA followup) <body> missing id and class Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>