If you place 3 holds on an item that is not on loan. Then check that item out to the person who is second in the queue, the holds are not reordered. They will be 1 and 3. This is because ModReserveFill deletes the hold from the reserves table, after putting it in the oldreserves table. It then passes the reserve id to _FixPriority. _FixPriority then queries the reserves table, and suprise suprise can't find the hold, and nothing is reordered.
Created attachment 34051 [details] [review] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have
Created attachment 34064 [details] [review] [SIGNED-OFF] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed the problem without the patch, and confirmed that the patch corrects it.
Created attachment 34148 [details] [review] [PASSED QA] Bug 13368 Holds priority messed up on checkout To Test 1/ Create 3 (or more holds) on one biblionumber, make sure at least one item is not on loan 2/ Check out the not on loan item to a borrower (maybe number 2 in the queue) 3/ Look in the database (or on the holds tab on the moredetail.pl) notice the priorities have not been reordered 4/ Apply patch and try again, notice now they have Signed-off-by: Owen Leonard <oleonard@myacpl.org> Confirmed the problem without the patch, and confirmed that the patch corrects it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Chris!
Pushed to 3.18.x will be in 3.18.2