We are trying to used AllowHoldsOnPatronsPossessions preference set to "Don't Allow" and it works only some times. opac-reserve.pl calls CheckIfIssuedToPatron($borrowernumber, $biblionumber) in Circulation.pm that calls GetItemsByBiblioitemnumber($biblionumber) in Items.pm that is using a query "SELECT * FROM items WHERE items.biblioitemnumber = ?" The problem is the query is searching for biblioitemnumber but we are passing biblionumber. I don't know if this is not a problem for other libraries but most of our biblioitemnumber DO NOT EQUAL biblionumber. It seems that we should not be using biblioitemnumbers for anything.
I only found 4 places using GetItemsByBiblioitemnumber() C4/Items.pm - function defined C4/Circulations.pm - called using biblionumber C4/ILSDI/Services.pm - called using biblioitemnumber intranet/cgi-bin/cataloguing/additem.pl - called using biblioitemnumber I propose: 1) renaming function to GetItemsByBiblionumber 2) changing all call to use biblionumber
(In reply to Jorge de Cardenas from comment #0) > We are trying to used AllowHoldsOnPatronsPossessions preference set to > "Don't Allow" and it works only some times. In master it seems to be working to block holds in the OPAC and staff client, so unless someone can come up with an exception I think this bug should be considered fixed.
I can reproduce this on master.
Created attachment 65158 [details] [review] Bug 13374 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now
Created attachment 65477 [details] [review] [SIGNED-OFF] Bug 13374 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 65489 [details] [review] Bug 13374 - AllowHoldsOnPatronsPossessions not working Test Plan: 1) Set AllowHoldsOnPatronsPossessions to "Don't" 2) Check out an item to a patron 3) Place a hold on that item for the same patron 4) Note you are allowed to with no alert 5) Delete the hold 6) Apply this patch 7) Place a hold on that item for the same patron 8) Note you recieve an alert now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I am not sure the patch fixes what has been reported originally. This patch fixes a problem added by commit bc39f0392bbebaad4c083f81308f652a325be042 Bug 14695 - Add ability to place multiple item holds on a given record per patron Which has been opened and pushed after this bug has been reported.
Kyle, I think a new bug report must be opened, the original issue seems fixed.
*** This bug has been marked as a duplicate of bug 19135 ***
(In reply to Nick Clemens from comment #9) > > *** This bug has been marked as a duplicate of bug 19135 *** Nope, it's not a duplicate, but it's fixed indeed.
*** Bug 15873 has been marked as a duplicate of this bug. ***