root@leibniz:/etc/cron.daily# ./koha-common library: env: /usr/share/koha/bin/cronjobs/automatic_renewals.pl: Permission denied root@leibniz:/etc/cron.daily# ls -l /usr/share/koha/bin/cronjobs/automatic_renewals.pl -rw-r--r-- 1 root root 1747 Nov 30 15:54 /usr/share/koha/bin/cronjobs/automatic_renewals.pl The file is 644 but should presumably be 755 since /etc/cron.daily/koha-common attempts to execute it.
Created attachment 34081 [details] [review] Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755
This is important enough for the packages to work correctly that I'm going to push it through QA. I've build squeeze-dev packages with it in, and it looks like it did the trick. It should be in the next 3.18 release.
Workaround until the next version is released (so I can point people here if it comes up on lists etc): sudo chmod +x /usr/share/koha/bin/cronjobs/automatic_renewals.pl
One the script is marked executable, it still has problems; there's no #! line at the top. Once that's added, the script seems to run without obvious problems.
Created attachment 34082 [details] [review] Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run.
Created attachment 34083 [details] [review] Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run.
Third time lucky, can you have a look and double check that this patch is sensible to you (it's still pretty simple, so I can't imagine much would go wrong.)
The patch in comment 6 looks reasonable; my sysadmin tested out the same changes and saw no obvious issues after making those same changes manually.
Patch pushed to master. Thanks Robin!
Pushed to 3.18.x will be in 3.18.01, Robin do you think it's worth rolling a new 3.18.0 with just this patch added to it? (It's only 18 days to 3.18.01 )