On the suggestion search page, the fund filter does not provide a way to search suggestions not linked to a fund.
Created attachment 34086 [details] [review] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option.
Created attachment 34168 [details] [review] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option.
The last patch simplifies the test in SearchSuggestion to make it more readable.
Created attachment 34169 [details] [review] [Signed-off] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 34367 [details] [review] [PASSED QA] Bug 13378: Add a filter to search suggestions not linked to a fund This patch adds a "None" option for the fund filter. Test plan: 1/ Go on the suggestion search page 2/ Search suggestions not linked to a fund using the "None" option. 3/ Search all suggestions (linked or not to a fund) using the "Any" option. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.3
Pushed to 3.16.x, will be in 3.16.7