But borrower_attribute_types is varchar(10). So if you try to link a patron attribute type with an AV category with a length > 10, the link won't be done. Also, I propose to extend this field to varchar(32).
Created attachment 34089 [details] [review] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something
Created attachment 34132 [details] [review] [SIGNED-OFF] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Error reproduced, fixed by patch.
Created attachment 34143 [details] [review] [PASSED QA] Bug 13379: Extends authorised_values.category to varchar(32) This patch does 2 things: 1/ It fixes a bug caused by the different data fields used for authorised_values.category and borrower_attribute_types.authorised_value_category (varchar(16) vs varchar(10)). To reproduce: - Create a AV category with a length > 10 - Try to link a patron attribute type with this AV, it won't work. 2/ Extends this field to varchar(32): sometime 16 is not enough to describe something Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Error reproduced, fixed by patch. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Just a note: aqbudgets.sort1_authcat and aqbudgets.sort2_authcat wre both varchar(80) - so there is another mismatch, although it should not cause any trouble. Not sure if we should shrink it to match and if so, we should do it on another bug).
Patch pushed to master. Thanks Jonathan!