In Koha 3.18 installed from Debian package are missing all 4 perl script for rotating collections. I've extracted the .deb file and these files are missing there too. Template files are OK.
This one is quite bad - rotating collections is one of the main new features... and it's missing from the packages.
Created attachment 34327 [details] [review] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too.
Created attachment 34391 [details] [review] [SIGNED OFF] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 34449 [details] [review] [PASSED QA] Bug 13398: rotating collections scripts are skipped on install This patch makes the Makefile.PL script pick the rotating_collections/ directory for install. To test: - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => FAIL: Verify that there is no 'rotating_collections' directory on the intranet CGI direcory. - Apply the patch - Run: $ perl Makefile.PL - Install using either 'standard' or 'single' method. => SUCCESS: Verify that there is a 'rotating_collections' directory on the intranet CGI direcory. - Sign off :-D Regards Tomas PS1: Note that it should be enough to check for the rotating_collections files on the generated Makefile after 'perl Makefile.PL'. PS2: The packages use the 'standard' install method to generate the file tree. So this patch should fix the packages too. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected.. even built a package with it for the belt and braces approach. As a side note, this just highlights the need for better packages testing.. there been a few of these with this release.. Sorry Tomas, I'll try harder as one of the few package testers in the future.
Patch pushed to master.
No string changes, pushed to 3.18.x will be in 3.18.2
(In reply to Chris Cormack from comment #7) > No string changes, pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x