Untranslatable javascript text: authorities/searchresultlist.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?'); authorities/detail.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?');
Created attachment 34176 [details] [review] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works.
Marc did you test by updating and installing a translation? I'm not sure if I'm testing incorrectly, but it's not working for me. 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. perl translate -v install de-DE 5. Testing deleting an authority from the authority search results page I still got the default English confirmation message.
Never mind. I needed to add step 3a. Delete the "fuzzy" marker from the entry in the po file. Thanks to cait for pointing out my error.
Created attachment 34278 [details] [review] [SIGNED-OFF] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly.
Created attachment 34346 [details] [review] [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34347 [details] [review] [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34348 [details] [review] [PASSED QA] Bug 13400 [QA Followup] - Fix tabs and quotes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Marc!
Holding for 3.18.3
Pushed to 3.18.x will be in 3.18.3
Contains string changes, holding for 3.16.8
Pushed to 3.16.x, will be in 3.16.7