To reproduce: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Message box asks for confirmation ("Change messaging preferences to default for this category?") Do the same in an other language Result: Text appears in English. Reason: JavaScript message is not surrounded by _(...) in memberentrygen.tt line 1343
Created attachment 34245 [details] [review] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?"
Created attachment 34276 [details] [review] [SIGNED-OFF] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 34343 [details] [review] [PASSED QA] Bug 13410 - Untranslatable "Change messaging preferences to default for this category?" To test: In staff client, go to Home > Patrons Click button "New patron" and choose a category Change Patron messaging preferences Now change Category Make sure that following message box still appears: "Change messaging preferences to default for this category?" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34344 [details] [review] Bug 13410 [QA Followup]
Patch pushed to master. Thanks Marc!
Contains string changes, holding for 3.18.3
Pushed to 3.18.x will be in 3.18.3
(In reply to Chris Cormack from comment #6) > Contains string changes, holding for 3.18.3 Contains string changes, holding for 3.18.8
(In reply to Mason James from comment #8) > (In reply to Chris Cormack from comment #6) > > Contains string changes, holding for 3.18.3 > > Contains string changes, holding for 3.18.8 oops ^ Contains string changes, holding for 3.16.8
Pushed to 3.16.x, will be in 3.16.7