Example: English: Modify Kind patron Hansli Meier Modify Erwachsener patron Henry Acevedo German: Ändern Kind Benutzer Hansli Meier Ändern Erwachsener Benutzer Henry Acevedo It should be something like English: Modify patron Hansli Meier (Kind) Modify patron Henry Acevedo (Erwachsener) Ändern Benutzer Hansli Meier (Kind) Ändern Benutzer Henry Acevedo (Erwachsener) Note: (Kind) and (Erwachsener) are set as Category name in Patron category administration.
Created attachment 34373 [details] [review] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile)
Still applies (Version 3.19.00.002)
Created attachment 34739 [details] [review] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Hm, bit confused - the description says it moves the category to the end, but that doesn't match what I see in the templates: When I edit an existing patron: Title: Modify Child patron <name> Breadcrumb: Home › Patrons › <name> › Modify Child patron Modify Adult patron Nicole Schneider Home › Patrons › Nicole Schneider › Modify Adult patron Double checked patch is applied and looking at the English templates. The categoryname at the end doesn't show up for me.
Hi Katrin, Did you test with the "Edit" links on the page, e.g. below "Date of birth" or "Library use"?
I checked the 'edit' in the toolbar and 'duplicate'
Created attachment 34763 [details] How it works now: Different Edit buttons show different titels / bradcrumbs for same patron
Created attachment 34764 [details] How it looks after patch (use "Edit" below Date of birth) and proposition how it should be for all kinds of editing (from toolbar or from links on page)
That's not what I saw - I will have to go back and retest, but right now not sure where I went wrong :(
No problem,I think the whole code is rather complicated. Please have a look at the proposition in my 2nd screenshot: The idea is to have both Category TYPE and category NAME, something like Modify patron Hansli Testmann (Child:Juvenile) ([TYPE]:[NAME]) If you think this would be OK I will provide a new patch.
Created attachment 34862 [details] [review] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile)
This patch creates invalid markup. I think it's just a missing </div>.
Created attachment 35258 [details] [review] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added)
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Created attachment 35417 [details] [review] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added) Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 35616 [details] [review] [PASSED QA] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added) Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 35617 [details] [review] Bug 13450 [QA Followup] - Remove tab character from start of line Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Marc!
Pushed to 3.18.x will be in 3.18.4
Possible selection for 3.16.x