Running prove t/db_dependent/Serials/Claims.t on any system with late subscriptions is going to trigger a failure. Temporary delete the subscriptions for testing purposes, and then rollback.
Created attachment 34371 [details] [review] Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools
Created attachment 34480 [details] [review] Bug 13456: Serials/Claims.t expects no subscriptions I've applied the patch against master 3.19.00.000 Everything is ok. So I pass the patch to "Signed Off" status. At my tests a "late subscription" is an open subscription with 1 (whichever) issue in LATE/3 state. About step 5/: koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 5bdf460 'Bug 13425 - XSS in opac facets - Patc') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK t/db_dependent/Serials/Claims.t OK critic OK forbidden patterns OK pod OK valid
Created attachment 34525 [details] [review] Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Mark!
(In reply to Paola Rossi from comment #2) [SNIP] > Processing files before patches > |========================>| 1 / 1 (100.00%) > Processing files after patches > |========================>| 1 / 1 (100.00%) [SNIP] Thanks to Paola Possi for making me check if there were updates to the QA test tool!
Pushed to 3.18.x, will be in 3.18.2