If RentalFeesCheckoutConfirmation system preference is activated, Koha will ask for confirmation for every checkout, even if there is no rental fine defined for the itemtype.
Created attachment 34383 [details] [review] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should
Created attachment 34415 [details] [review] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used I've applied the patch against 3.19.00.000 Everything is OK as required. So I pass the patch to "Signed Off" status.
Created attachment 34450 [details] [review] [PASSED QA] Bug 13461 - Circ always asking for confirmation if RentalFeesCheckoutConfirmation is used To test: - Check RentalFeesCheckoutConfirmation is activated - Try to check out an item without rental fine - Verify confirmation message without explanation is shown - Apply patch - Verify confirmation message is no longer shown - Configure itemtype to have rental fee - Veirfy now the confirmation message appears as it should Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Works as expected, super trivial but super needed patch.. Passing QA Thanks Katrin :)
Pätch pushed to master. Gracias Katrina!
Pushed to 3.18.x, will be in 3.18.2
(In reply to Chris Cormack from comment #6) > Pushed to 3.18.x, will be in 3.18.2 skipping patch for 3.16.x