Bug 13464 - Standardize the pagination class
Summary: Standardize the pagination class
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-15 12:00 UTC by paxed
Modified: 2016-12-05 21:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13464 - Standardize the pagination class (7.36 KB, patch)
2016-03-21 13:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13464 - Standardize the pagination class (7.45 KB, patch)
2016-03-23 11:08 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 13464 - Standardize the pagination class (7.62 KB, patch)
2016-03-23 21:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-12-15 12:00:36 UTC
Most templates use class "pages" for pagination controls, but few use class "paginationBar" and one uses id "pagination-bar"

The "pages" class already has css styles, so all pagination controls should use the same class.
Comment 1 Owen Leonard 2016-03-21 13:55:32 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-03-23 11:08:36 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-03-23 21:31:29 UTC
Created attachment 49465 [details] [review]
Bug 13464 - Standardize the pagination class

There are a few template which use a different wrapper class for the
pagination links. These should be made consistent for a consistent
style.

To test, apply the patch and go to Administration -> Budgets.

- On this page the pagination markup has been removed in favor of
  DataTables pagination. The budget tables were already sorted using
  DataTables, so having server-side pagination on top of that doesn't
  make sense.

In Administration -> Class sources:

- This page had pagination markup which was unused.

In Authorities -> Authority search results:

- Perform an authority search which will return more than one page of
results. Confirm that the pagination links are correctly styled.

In Search -> Item search:

- Perform a search which will return more than one page of results.
Confirm that the pagination links are correctly styled.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Since the funds are all displayed (and nobody complained), it makes sense to
display all budgets.
Comment 4 Brendan Gallagher 2016-03-23 23:05:34 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!