Currently, Unapi points to C4::Context->config('intranetdir')."/koha-tmpl/intranet-tmpl/prog/en/xslt/". However, it should point to C4::Context->config('intrahtdocs')."/prog/en/xslt/". The first path is set up just to work with a Git install, while the latter will work on every install.
Created attachment 34444 [details] [review] Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now.
Created attachment 34484 [details] [review] Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine.
Created attachment 34530 [details] [review] [PASSED QA] Bug 13469 - Unapi path to XSLTs is wrong in OPAC The Unapi path to XSLTs is wrong in the OPAC. Unfortunately, it's coded to work just for Git installs, which makes it tough to test. _TEST PLAN_ Before applying: 1) Go to http://GIT-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) If the biblionumber exists, it should show you the record in OAI_DC format. 3) Go to http://REGULAR-INSTALL/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 4) You should get a software error Apply the patch. After applying: 1) Refresh the page for http://yourgitinstall/cgi-bin/koha/unapi?id=koha:biblionumber:1&format=oai_dc 2) It should work exactly the same as before. Thorough testers: 1) Push the code to that regular test install 2) Try the link again. It will properly show the converted record now. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Verified that single install intrahtdocs==/usr/share/koha/clone1712/intranet/htdocs/intranet-tmpl plus "/prog/en/xslt/" is the location for the required xslt files. Script unapi in git install is still fine. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks David!
Pushed to 3.18.x, will be in 3.18.2
Pushed to 3.16.x, patch will be in 3.16.7