The patch set will add the location column to the checkouts tables (circ/circulation.pl and members/moremember.pl). On the way, it will also add the column settings for these tables.
Created attachment 34662 [details] [review] Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected).
Created attachment 34663 [details] [review] Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected).
Created attachment 34664 [details] [review] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin).
Tried to test but got the following errors when applying patch it depends on from Bug 10212: Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt CONFLICT (add/add): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc CONFLICT (add/add): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc Auto-merging admin/columns_settings.yml CONFLICT (add/add): Merge conflict in admin/columns_settings.yml Auto-merging C4/Utils/DataTables/ColumnsSettings.pm CONFLICT (add/add): Merge conflict in C4/Utils/DataTables/ColumnsSettings.pm Failed to merge in the changes. Patch failed at 0001 Bug 10212: Columns configuration for tables Setting to Patch doesn't apply
Hi Aleisha, bug 10212 is already pushed to master, you don't need to apply it.
Created attachment 35481 [details] [review] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 35511 [details] [review] [PASSED QA] Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 35512 [details] [review] [PASSED QA] Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 35513 [details] [review] [PASSED QA] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38434 [details] [review] Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38435 [details] [review] Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38436 [details] [review] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38473 [details] [review] Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Amended patch: replace 'un' and 'deux' with 'sort_order' and 'todays_or_previous_checkouts' in the yml file. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38474 [details] [review] Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master. Good job Jonathan!