Steps to reproduce: - Launch the webinstaller (I deleted my DB to do it) - The login screen shows => FAIL: "Koha 3.0 Installer" is hidden inside the code. It seems to be intended for screen readers to tell it (I cannot test that feature) but I think it is showing the wrong version, and it shouldn't.
Created attachment 34777 [details] [review] Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D
Created attachment 34778 [details] [review] Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D
Created attachment 34852 [details] [review] Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34853 [details] [review] Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 34899 [details] [review] [PASSED QA] Bug 13496: add a method for the templates to print Koha version as desired This patch introduces a simple template plugin function that returns the Koha version number in different suitable formats. It introduces unit tests for the new function. They are run with To test: - Apply the patch - Run $ prove t/Koha_Template_Plugin_Koha.t => SUCCESS: the tests pass. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 34900 [details] [review] [PASSED QA] Bug 13496: make auth.tt use a template plugin to get the Koha version This patch makes the installer login template use the new Koha.Version template plugin to get the correct Koha version. This way we don't need to maintain the auth.tt file on each version change, and are sure screen readers tell the correct version. To test: - Create a situation where the login screen from the installer shows - Navigate the HTML code (Ctrl+u) => FAIL: "Koha 3.0 Installer" shows on the HTML code - Apply the patch - Reload the page => SUCCESS: The correct version number is shown. - Sign off :-D Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master.